The MobileDiff page no longer exists, and was replaced with a redirect
that redirects to the desktop diff page, so this code can safely
be removed.
Bug: T360389
Change-Id: I8ebe2bc88a650caf29a5755013e980fe3b5aaeb0
It looks like there is nothing special about this module. It is
loaded the same time as the other "lazy" module, under the same
conditions.
Change-Id: Iae3e425297ef5ed3f35cb8c8d66b390875158905
User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here.
Bug: T352284
Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52
Change-Id: I4daca7542a428455aa72cc372521e894716e3c40
Notable:
* Arrays shouldn't be initialized like this. Instances will actually
share the same array object. Luckily this was dead code anyway
because it's re-done in the constructor.
* $timeOffset is already guaranteed to be an int.
Change-Id: Ib0a2b0f39ee368fcef4756281099d519d470eb44
Really just a mistake.
Also make use of strict types while we are here. We can do this now
with our minimum PHP version.
Change-Id: Iab83a4c538b648f19a803442d1e839389f4d9cc4
I removed this aria-hidden, because the RevisionSlider as a whole
can be accessed with the focusable button that expands the UI.
Elements that are focusable should not be aria-hidden.
screenreaders in general will allow interaction with these or even
might show unpredictable behavior.
Screenreader and keyboard support for the feature is not good but
this aria-hidden is useless and wrong at the moment.
Bug: T339254
Change-Id: I8b8e3938cba701c821d4fd2ee3c2f90bf7610623
This is cached anyway in the ConfigFactory. On top of that this
is called a single time only. The cache is not even used.
As far as I can tell this pattern was originally copied from
another extension with more than one hook handler.
Change-Id: Idb88bcba753a99d30cd52cf520257298fad7259a
The title returned by DifferenceEngine::getTitle() will change with
I2120d52 (T245172).
Bug: T245172
Change-Id: I092071573a779cc20c33d25d2a495cbf1e22db4b
Each RL module comes with the cost of its name + hash being sent over every
request and in the startup module increasing the time to load the page.
Bug: T229791
Change-Id: I3ae230a84112a70ab369ffbff70e173b8f07ec1a
Using rawElement function to generate a new html element for loading spinner.
This replaces the progress bar widget.
Bug: T161640
Change-Id: I949bce945def25de561c0ae0df971c3f609586ce
The arrow in Revision Slider flips on expand and collapse which is not according to the standard of OOUI.
Bug: T198626
Change-Id: I4205a2260e8507a09f2950566e5033bd58a74345
- added function spacing checks and fixed code
- removed vendor excludes since they are part of MW-CS
- reduced extensions to php, nothing else used here
Change-Id: I8dbdede97be965313e17357fa560d1c7e04686fb
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.
Bug: T183858
Change-Id: I3e7a12a224f4c1563a467eeff74ba0f118aa8f00
The RevisionSlider is not ready for the MobileDiff right now, so
do not include him on the MobileDiff page, even when the hook is
called.
Bug: T169535
Change-Id: I190a8681adad4e8605ae5c8bd69399459f364238
Sometimes $oldRev can be null (e.g. not a Revision, but
maybe is a missing revision), and also not sure we can be
certain about $newRev being a Revision object.
Bug: T167359
Change-Id: I4c483d711f2ec07a918c708a473aff1b2c150cf5
Until the sliding mechanism has full support to work with screen-
readers the tool will be disabled for them to avoid unnecessary
confusion.
Bug: T165489
Change-Id: Id0da2c891040ac7e6f1b6ce5ba5f65b727d3cb07
This currently just works, because the currently used backend are
global variables. Once the main config uses a more scoped/focused
backend, such as a HashConfig or a database-based config, requesting
extension configurations from it will not work anymore.
Therefore, use the extensions Config object to request configuration
options for the extension.
Change-Id: Iea02d3c284f9a0e12abff33e3624dce9585ab51c
