Commit graph

135 commits

Author SHA1 Message Date
thiemowmde 363f24a409 Remove dead code from HelpDialog test
There are not even any <a> elements involved because the language is
set to qqx.

Change-Id: I64a6c414ccb327bc65a606ebd1579b579cd3215a
2024-04-29 11:59:14 +02:00
Fomafix c930a7a88e Use .parseDom() from mediawiki.jqueryMsg instead of .parse()
This generates the DOM elements directly instead of generating and
parsing HTML.

Also move the dependency on module 'mediawiki.jqueryMsg' from module
'ext.RevisionSlider.init' to module 'ext.RevisionSlider.Slider'.

Change-Id: I3a93b942e08ff7453e2b940c7f3e896f90679d0d
2024-04-26 14:14:01 +00:00
Fomafix a0d76d6f4a Move dependency on module 'mediawiki.util'
from module 'ext.RevisionSlider.init'
to module 'ext.RevisionSlider.Settings'
where mw.Api is used.

Change-Id: Idcc0e3e670fa3eddb0cd121b1de42aabca6bd6ae
2024-04-25 18:53:27 +00:00
thiemowmde af86647d5c Merge separate "noscript" CSS module
It looks like there is nothing special about this module. It is
loaded the same time as the other "lazy" module, under the same
conditions.

Change-Id: Iae3e425297ef5ed3f35cb8c8d66b390875158905
2024-02-26 17:54:53 +01:00
Fomafix aadedc996f Use MediaWiki\ResourceLoader\ImageModule instead of ResourceLoaderImageModule
The class name ResourceLoaderImageModule is deprecated since 1.39.

Change-Id: I1ef11649f10f4114372685ca20177227f06b1237
2023-12-01 13:27:37 +00:00
gerritbot 639d3fa19c Update UserOptionsLookup's FQN
User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here.

Bug: T352284
Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52
Change-Id: I4daca7542a428455aa72cc372521e894716e3c40
2023-11-29 12:39:57 +00:00
jenkins-bot 7a64be70c3 Merge "build: Update MediaWiki requirement to 1.41" 2023-08-31 05:24:20 +00:00
thiemowmde 10931b6210 Remove obsolete per-skin CSS
This is obsolete since I75ef7c3 where we had to replace the
`font-size: 0.8em` with a fixed 13px.

Bug: T341872
Change-Id: I81603536dd930c6faee38c63aabe848203c42715
2023-08-29 17:29:20 +02:00
James D. Forrester 0c23f638c8 build: Update MediaWiki requirement to 1.41
All extensions in Wikimedia production are expected to track MediaWiki's release directly.

Change-Id: I9396997261ad6ec407f87321b4cff774b9798f45
2023-08-19 14:04:20 +08:00
Adam Wight b900446572 Migrate JS to ES6
Reintroduces IIFE closures in test files because variables were
declared in the global namespace, and "const" now causes hard errors.

Bug: T339323
Change-Id: I69e9d7a29591137f185f3e5ab02dea590ec4dff6
2023-06-23 08:01:31 +02:00
thiemowmde bbf3b67bad Use "0" instead of "false" for default user options
This is best-practice, as far as I can see. It doesn't make a
difference in terms of what is stored in the database. false,
the number 0 and the string "0" will all be stored as "0" in the
database. More precisely: These values will not be stored because
they are all considered equal to the default value by
UserOptionsManager::isValueEqual().

It makes a difference in terms of what is send to the browser. The
keyword "false" is 5 bytes while "0" is only one.

Bug: T300371
Change-Id: Ia9eb03ebdc2155df1785fa5d40bceaab56268bf9
2023-06-12 10:01:46 +02:00
Sam Wilson e70d7b7ed6 Update to use the new HookContainer/HookRunner system
Implement hook handlers and inject services.

Bug: T335085
Change-Id: Ibe68029561098d90a0ee0b9fa70b1c4866996426
2023-04-20 11:28:28 +08:00
Reedy 00d9f42d5e Correct namespacing to match best practices
Bug: T303105
Change-Id: I44529699d6dc9564633a9d61ad11ea150767b9ad
2022-03-05 15:08:35 +00:00
Thiemo Kreuz 9aca3a2593 Merge ….RevisionList ResourceLoader module away
It's never used in another context but together with the
….Slider module.

Motivated by the confusion about the two types of require()
introduced in Idf1cc79.

Bug: T233279
Change-Id: I922d7ab56fd3ce80bc901f1a5d7174df6fe6756d
2021-12-20 12:13:09 +01:00
jenkins-bot d8c013e323 Merge "Merge ….HelpDialog ResourceLoader module away" 2021-12-17 13:48:22 +00:00
jenkins-bot fd8b96b791 Merge "Merge ….Pointer ResourceLoader module away" 2021-12-17 13:48:20 +00:00
Thiemo Kreuz 1407e0a90d Merge ….HelpDialog ResourceLoader module away
It's never used in another context but together with the
….Slider module as well as the ….init module. The ….init
module continues to require the ….Slider module, so all
dependencies are still met.

Motivated by the confusion about the two types of require()
introduced in Idf1cc79.

Bug: T233279
Change-Id: I4b4ef69f3074d57f884763c092a515ce976daaef
2021-12-16 16:45:41 +01:00
Thiemo Kreuz 319061c92a Merge ….Pointer ResourceLoader module away
It's never used in another context but together with the
….Slider module.

Motivated by the confusion about the two types of require()
introduced in Idf1cc79.

Bug: T233279
Change-Id: I7c98a41051e6d83ab3524cb14a709002feec2d78
2021-12-16 16:39:07 +01:00
Umherirrender 8097a15140 Add revisionslider-disable to DefaultUserOptions
Without the default the preference is never deleted from the database,
even it was disabled by the user.

Bug: T291748
Change-Id: Iac622126ab3f5088d8c7177cd82c006e81fbe4e1
2021-09-29 01:16:59 +02:00
Adam Wight 8132e43a20 Migrate Slider module to packageFiles
Change-Id: Idf1cc799ab37ec8f49b3a28d161b6cd53090f707
2020-11-19 09:13:45 +00:00
Adam Wight ebd9985afc Migrate RevisionList to packageFiles
Change-Id: I3299d3a4bc66a3b85d0d0f7d8a49edbf8f6329c3
2020-11-19 08:54:10 +00:00
WMDE-Fisch 1a59b36dd1 Use Wikimedia Deutschland in credits
Bug: T244059
Change-Id: I3fe1fba80dc1b1bd3a174e83b68fa01b217979a1
2020-11-17 10:53:23 +01:00
WMDE-Fisch e0aadec6f2 Remove unnecessary module from init package
Change-Id: Ic353bc2635376aded4ee29cc58985eec48254305
2020-11-12 13:25:20 +01:00
WMDE-Fisch 97ef338e86 Replace outdated TCB team authorship in credits
Bug: T244059
Change-Id: Ic4d0643d2e916882643ee7082510ae0a4a80779a
2020-11-03 13:41:33 +01:00
Adam Wight ddcd65f4de Migrate Pointer to packageFiles
Change-Id: I8e06c9eeb47688741a95bca8f996b2148b03028c
2020-09-21 18:14:07 +00:00
jenkins-bot 1e13c311e8 Merge "Migrate HelpDialog to packageFiles" 2020-09-21 07:21:33 +00:00
DannyS712 8e1ed89152 Update hooks to use DifferenceEngineViewHeader, require MW 1.35+
Bug: T255769
Change-Id: I0d64099dd4caffc5b9631fc743bfe229868f46a8
2020-06-24 01:15:45 +00:00
Reedy 706d16715f Convert to manifest_version 2
Bug: T252470
Change-Id: I075fbf8f81ee9800f50ebded3d77cdf2f937f79c
2020-05-12 00:07:46 +01:00
Reedy d8da8ab98a Namespace extension
Change-Id: I0cd732fc28bf2b152281f3318c17215d519c32db
2020-04-19 01:10:58 +00:00
Adam Wight c9958c5edd Migrate HelpDialog to packageFiles
FIXME: Reusing HelpDialog as a module entrypoint creates a circular
reference.  It's harmless because the dependencies are added at
different times, but also easy to refactor away.

Change-Id: I3608a78baddf2376cc9eb4524625f4911c130c06
2020-04-05 01:50:48 +02:00
Adam Wight d369701709 Migrate Settings module to packageFiles
Change-Id: I984404dd216fff469d7891f4f69a92d83d19d1c4
2020-04-05 01:37:15 +02:00
Adam Wight fcae356705 Migrate init module to packageFiles
Change-Id: I19ac9d27e365357bfeed649106663d49e7f82d6f
2020-04-05 01:36:46 +02:00
Adam Wight ece7649624 Migrate lazy JS to packageFiles
This is a no-op.

Change-Id: I7be09dac70ff7e22f6ea5a76aac7af5f232fca35
2020-04-05 01:35:22 +02:00
Adam Wight 512d99e6a9 Declare QUnit test modules in extension.json
Newer, declarative syntax for QUnit test modules.

Change-Id: Ifb0064a4891293a29e9a2a9a0e34c106f7614a72
2020-03-30 00:01:22 +02:00
Adam Wight c685ea38f7 Remove redundant file pointer
util.js belongs in the Slider module, this duplicate line was in error.

Change-Id: I85573610261c015e8b93c5207f283923d4deb387
2020-03-29 23:24:34 +02:00
Thiemo Kreuz 7ec4910595 Remove misleading version number 1.0 from extension.json
This version number does not have any meaning (never had). It's
misleading, if not wrong. All code WMDE maintains is deployed weekly.
Branches are cut at a fixed time. Nobody ever assigned version
numbers to these releases.

The number is not used in communication. The only place where it
appears is Special:Version, but is useless there. Users can't use
it for anything. I talked to all relevant parties (product manager,
communication) and nobody ever used this version number. Because of
this, this is a purely technical task to get rid of unnecessary
technical dept.

Bug: T213066
Change-Id: I9950b31a1d99d1778e104d9840368b9f585aaa55
2020-01-28 15:54:29 +01:00
Thiemo Kreuz bc71d50cd8 Simplify Hooks section in extension.json
It is possible, but very rare to have more than a single hook handler
per hook in a single extension. The value can be an array or string in
both version 1 and 2 of extension.json.

Change-Id: I814127488cd54464d675ca901c6f32b066fb2ee3
2020-01-24 18:36:55 +01:00
Timo Tijhof f0720b6eaf Remove use of jquery.ui module aliases
This increases the extension's dependency to MW 1.34+.

Bug: T219604
Change-Id: I566b163969c66572c3b8de41e4250606df85e4ca
2019-10-20 10:48:39 +01:00
jenkins-bot 4949c15d0c Merge "Replace expand icon with down indicator" 2019-08-17 13:19:45 +00:00
tzhelyazkova a5d329758a Replace expand icon with down indicator
Bug: T212803
Change-Id: Ic0ae23bbc399ce70764457bbf4d789f113fb2f48
2019-08-15 11:47:14 +02:00
Amir Sarabadani 111d108150 Merge some resource loader modules
Each RL module comes with the cost of its name + hash being sent over every
request and in the startup module increasing the time to load the page.

Bug: T229791
Change-Id: I3ae230a84112a70ab369ffbff70e173b8f07ec1a
2019-08-14 23:10:25 +02:00
gopavasanth e4c31f762b Replace custom 'pin' by 'pushPin' icon
Modified CSS of the pushPin

Bug: T194613
Change-Id: Ifdaa2567c67a45fd44bea7cc4718f29c4e1a58fd
2018-08-30 20:31:04 +05:30
Thiemo Kreuz 3520a606c9 Limit fetchUserGenderData to maximum 50 users
The 50 is the default. The worst-case scenario here is that users
beyond this limit don't have a gender for a while, until the next call
to the same API endpoint fetches the next 50 users with an unknown
gender.

Doing multiple API calls in advance is not worth it, in my opinion.

Bug: T197858
Change-Id: I0fdcc7ea96a6a5ee3934600c6f0fdc65263276e8
2018-07-04 10:44:27 +00:00
Fomafix 33b2b584a2 Remove dependencies on deprecated modules 'mediawiki.api.*'
In core, modules 'mediawiki.api.*' got merged into 'mediawiki.api' and
deprecated in I0afdc8ab50bc1354bb5099bf39923c07eab0b665.

This change increases the requirement to MediaWiki 1.32 or higher.

Change-Id: I60601c8fe97b251e8e2a186dec0149bbc1169f01
2018-05-31 14:28:38 +00:00
zoranzoki21 c6e469ddc5 Removed deprecated position statements from resource loader module
Bug: T184257
Change-Id: I7b1fc3cf8e92d31b77b6cd69c832652b47873046
2018-02-03 17:35:56 +01:00
WMDE-Fisch ad760e90d7 Use SPDX 3.0 license identifier
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.

Bug: T183858
Change-Id: I66f232a6a0fd03ff51cc0b4c87ee7b6f50edf439
2018-01-04 11:42:37 +01:00
Volker E e868a33116 Refactor RevisionSlider toggle button CSS
including:
- Using LESS for nested CSS
- Overrule `margin` of frameless OOUI `mw-revslider-toggle-button`
- Removing CSS that had no effect since some time
- Removing `!important` where not longer needed

Change-Id: I1ba01061ebafe799ca62dbb6ce5e79459612af23
2017-11-17 12:06:06 +00:00
Ed Sanders 684c6c4b0c Use LESS color calculation for blue/yellow slider styling
Change-Id: I7220acf4b5c4a70f56cde67269c09cd3bf757f19
2017-10-27 19:54:43 +01:00
Fomafix 82427b09bc Fix dependencies to core modules
Add dependency on module 'mediawiki.util' for module
'ext.RevisionSlider.DiffPage' because
modules/ext.RevisionSlider.DiffPage.js uses mw.util.wikiScript.

Remove dependency on module 'mediawiki.util' for module
'ext.RevisionSlider.RevisionList' because this module does not use any
functions from mw.util directly.

Remove dependency on module 'mediawiki.user' for module
'ext.RevisionSlider.init' because this module uses only mw.user.options
which is generated in core module 'mediawiki' and not in
'mediawiki.user'.

Change-Id: Ifc6a20de667a410b9890fdc1fcba3319beb061de
2017-08-27 16:55:29 +02:00
mdew192837 d665c03e0a Monobook uses x-small and a globalWrapper to make everything inside
of it appear normal. However, the revslider-tooltips are not inside
this globalWrapper, and thus need a separate CSS rule.

Bug: T166231
Change-Id: I2115688fee75145349e062b9586713a56541afa0
2017-08-09 10:49:24 -05:00