wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-14 19:24:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused dir property from RevisionListView

Browse source 
The property is unused since I883a502 from 2017.

Change-Id: Idb61db8615038f136982f74f67960a2f86e1b3ff
This commit is contained in:
thiemowmde 2024-03-12 17:38:57 +01:00
parent c75ba6880b
commit e8a327fd85
3 changed files with 3 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
modules/ext.RevisionSlider.RevisionListView.js
View file

@ -1,12 +1,10 @@
/** /**
* @class RevisionListView * @class RevisionListView
* @param {RevisionList} revisionList * @param {RevisionList} revisionList
* @param {string} [dir]
* @constructor * @constructor
*/ */
function RevisionListView( revisionList, dir ) { function RevisionListView( revisionList ) {
this.revisionList = revisionList; this.revisionList = revisionList;
this.dir = dir;
} }
$.extend( RevisionListView.prototype, { $.extend( RevisionListView.prototype, {
@ -40,11 +38,6 @@ $.extend( RevisionListView.prototype, {
*/ */
allowRevisionPreviewHighlights: true, allowRevisionPreviewHighlights: true,
/**
* @type {string}
*/
dir: null,
/** /**
* @type {string} * @type {string}
*/ */
@ -683,15 +676,6 @@ $.extend( RevisionListView.prototype, {
); );
}, },
/**
* Set direction for the view
*
* @param {string} dir
*/
setDir: function ( dir ) {
this.dir = dir;
},
/** /**
* @return {jQuery} * @return {jQuery}
*/ */

4
modules/ext.RevisionSlider.SliderView.js
View file

@ -1054,7 +1054,7 @@ $.extend( SliderView.prototype, {
// loaded revision. This should be taken into account when rendering newly loaded revisions (tooltip) // loaded revision. This should be taken into account when rendering newly loaded revisions (tooltip)
const revisionsToRender = this.slider.getRevisionList().slice( revPositionOffset ); const revisionsToRender = this.slider.getRevisionList().slice( revPositionOffset );
const $addedRevisions = new RevisionListView( revisionsToRender, this.dir ).render( this.revisionWidth, revPositionOffset ); const $addedRevisions = new RevisionListView( revisionsToRender ).render( this.revisionWidth, revPositionOffset );
this.addClickHandlerToRevisions( $addedRevisions ); this.addClickHandlerToRevisions( $addedRevisions );
$addedRevisions.find( '.mw-revslider-revision-wrapper' ).each( function () { $addedRevisions.find( '.mw-revslider-revision-wrapper' ).each( function () {
@ -1094,7 +1094,7 @@ $.extend( SliderView.prototype, {
// loaded revision. This should be taken into account when rendering newly loaded revisions (tooltip) // loaded revision. This should be taken into account when rendering newly loaded revisions (tooltip)
const revisionsToRender = this.slider.getRevisionList().slice( 0, revs.length ); const revisionsToRender = this.slider.getRevisionList().slice( 0, revs.length );
const $addedRevisions = new RevisionListView( revisionsToRender, this.dir ).render( this.revisionWidth ); const $addedRevisions = new RevisionListView( revisionsToRender ).render( this.revisionWidth );
this.addClickHandlerToRevisions( $addedRevisions ); this.addClickHandlerToRevisions( $addedRevisions );
if ( this.getOlderPointerPos() !== -1 ) { if ( this.getOlderPointerPos() !== -1 ) {

1
modules/ext.RevisionSlider.init.js
View file

@ -47,7 +47,6 @@ function initialize() {
SliderModule.makeRevisions( revs ), SliderModule.makeRevisions( revs ),
changeTags changeTags
); );
revisionList.getView().setDir( $container.css( 'direction' ) || 'ltr' );
const slider = new Slider( revisionList ); const slider = new Slider( revisionList );
slider.getView().render( $container ); slider.getView().render( $container );