wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-12-13 07:48:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update pointer position attributes immediately

Browse source 
Update attributes right after setting position and
don't wait until revisions are refreshed.

Change-Id: Ic32a554d6939806ce95d4e7b441ee08965b81940
This commit is contained in:
Tobias Gritschacher 2016-10-12 15:31:38 +02:00
parent 5553fe0688
commit da8f7fb064
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ext.RevisionSlider.SliderView.js
View file

@ -306,12 +306,14 @@
if ( hasClickedTop ) { if ( hasClickedTop ) {
pNew.setPosition( parseInt( $clickedRev.attr( 'data-pos' ), 10 ) ); pNew.setPosition( parseInt( $clickedRev.attr( 'data-pos' ), 10 ) );
view.updatePointerPositionAttributes();
view.refreshRevisions( view.refreshRevisions(
view.getRevElementAtPosition( $revisions, pOld.getPosition() ).data( 'revid' ), view.getRevElementAtPosition( $revisions, pOld.getPosition() ).data( 'revid' ),
$clickedRev.data( 'revid' ) $clickedRev.data( 'revid' )
); );
} else { } else {
pOld.setPosition( parseInt( $clickedRev.attr( 'data-pos' ), 10 ) ); pOld.setPosition( parseInt( $clickedRev.attr( 'data-pos' ), 10 ) );
view.updatePointerPositionAttributes();
view.refreshRevisions( view.refreshRevisions(
$clickedRev.data( 'revid' ), $clickedRev.data( 'revid' ),
view.getRevElementAtPosition( $revisions, pNew.getPosition() ).data( 'revid' ) view.getRevElementAtPosition( $revisions, pNew.getPosition() ).data( 'revid' )
@ -321,7 +323,6 @@
view.resetPointerColorsBasedOnValues( view.pointerOlder.getPosition(), view.pointerNewer.getPosition() ); view.resetPointerColorsBasedOnValues( view.pointerOlder.getPosition(), view.pointerNewer.getPosition() );
view.resetRevisionStylesBasedOnPointerPosition( $revisions ); view.resetRevisionStylesBasedOnPointerPosition( $revisions );
view.alignPointers(); view.alignPointers();
view.updatePointerPositionAttributes();
}, },
/** /**