wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-30 18:14:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use "0" instead of "false" for default user options

Browse source 
This is best-practice, as far as I can see. It doesn't make a
difference in terms of what is stored in the database. false,
the number 0 and the string "0" will all be stored as "0" in the
database. More precisely: These values will not be stored because
they are all considered equal to the default value by
UserOptionsManager::isValueEqual().

It makes a difference in terms of what is send to the browser. The
keyword "false" is 5 bytes while "0" is only one.

Bug: T300371
Change-Id: Ia9eb03ebdc2155df1785fa5d40bceaab56268bf9
This commit is contained in:
thiemowmde 2023-06-12 09:56:19 +02:00
parent 2d4dde3e67
commit bbf3b67bad
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -195,6 +195,6 @@
} }
}, },
"DefaultUserOptions": { "DefaultUserOptions": {
"revisionslider-disable": false "revisionslider-disable": 0
} }
} }