wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-23 23:13:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Add fail-safe to SliderView.revisionsClickHandler"

Browse source
This commit is contained in:
jenkins-bot 2023-12-07 10:53:04 +00:00 committed by Gerrit Code Review
parent 7a5e15527e c634608057
commit b395d66270
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ext.RevisionSlider.SliderView.js
View file

@ -315,8 +315,12 @@ $.extend( SliderView.prototype, {
*/
revisionsClickHandler: function ( event ) {
const clickedPos = this.getRevisionPositionFromLeftOffset( event.pageX ),
$revisionWrapper = this.getRevElementAtPosition( this.getRevisionsElement(), clickedPos ).parent(),
hasClickedTop = event.pageY - $revisionWrapper.offset().top < $revisionWrapper.height() / 2;
$revisionWrapper = this.getRevElementAtPosition( this.getRevisionsElement(), clickedPos ).parent();
// Fail-safe in case a mouse click outside the valid range is picked up
if ( !$revisionWrapper.length ) {
return;
}
const hasClickedTop = event.pageY - $revisionWrapper.offset().top < $revisionWrapper.height() / 2;
let newNewerPointerPos, newOlderPointerPos;
if ( hasClickedTop &&