wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-30 18:14:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Drop custom forEach loop in favor of native Array.find()"

Browse source
This commit is contained in:
jenkins-bot 2023-10-26 12:01:09 +00:00 committed by Gerrit Code Review
parent 46185aecae d85496a2a8
commit 43b185fdbe
1 changed files with 8 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
modules/ext.RevisionSlider.RevisionListView.js
View file

@ -254,10 +254,12 @@ $.extend( RevisionListView.prototype, {
* @param {jQuery} $revisionWrapper
*/
showTooltip: function ( $revisionWrapper ) {
const pos = +$revisionWrapper.find( '.mw-revslider-revision' ).attr( 'data-pos' ),
revId = +$revisionWrapper.find( '.mw-revslider-revision' ).attr( 'data-revid' ),
revision = this.getRevisionWithId( revId );
if ( revision === null ) {
const $revision = $revisionWrapper.find( '.mw-revslider-revision' );
const revId = +$revision.attr( 'data-revid' );
const pos = +$revision.attr( 'data-pos' );
const revision = this.revisionList.getRevisions().find( ( rev ) => rev.getId() === revId );
if ( !revision ) {
return;
}
@ -287,20 +289,6 @@ $.extend( RevisionListView.prototype, {
$revisionWrapper.addClass( 'mw-revslider-revision-wrapper-hovered' );
},
/**
* @param {number} revId
* @return {Revision|null}
*/
getRevisionWithId: function ( revId ) {
let matchedRevision = null;
this.revisionList.revisions.forEach( function ( revision ) {
if ( revision.getId() === revId ) {
matchedRevision = revision;
}
} );
return matchedRevision;
},
/**
* Sets event handlers on tooltips so they do not disappear when hovering over them
*/
@ -369,14 +357,14 @@ $.extend( RevisionListView.prototype, {
* @return {string}
*/
getUserPage: function ( user ) {
return ( mw.util.isIPAddress( user, false ) ? 'Special:Contributions/' : 'User:' ) + this.stripInvalidCharacters( user );
return ( mw.util.isIPAddress( user ) ? 'Special:Contributions/' : 'User:' ) + this.stripInvalidCharacters( user );
},
/**
* Generates the HTML for the user label
*
* @param {string} userString
* @param {string} userGender
* @param {string} [userGender='unknown']
* @return {string|jQuery}
*/
makeUserLine: function ( userString, userGender ) {