wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-23 15:06:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

migrate metrics to StatsFactory

Browse source 
Bug: T359244
Change-Id: I0c0a23535dd8b3114d18157f29ad0bbb2afb2a02
This commit is contained in:
Cole White 2024-11-05 21:01:18 +00:00
parent b9c29995bb
commit 35af63c202
3 changed files with 18 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -183,7 +183,7 @@
"services": [
"ConfigFactory",
"UserOptionsLookup",
"StatsdDataFactory"
"StatsFactory"
]
}
},

22
src/RevisionSliderHooks.php
View file

@ -2,7 +2,6 @@
namespace MediaWiki\Extension\RevisionSlider;
use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
use MediaWiki\Config\Config;
use MediaWiki\Config\ConfigFactory;
use MediaWiki\Diff\Hook\DifferenceEngineViewHeaderHook;
@ -14,6 +13,8 @@ use MediaWiki\Revision\RevisionRecord;
use MediaWiki\User\Options\UserOptionsLookup;
use MediaWiki\User\User;
use OOUI\ButtonWidget;
use Wikimedia\Stats\Metrics\CounterMetric;
use Wikimedia\Stats\StatsFactory;
/**
* RevisionSlider extension hooks
@ -26,16 +27,17 @@ class RevisionSliderHooks implements DifferenceEngineViewHeaderHook, GetPreferen
private Config $config;
private UserOptionsLookup $userOptionsLookup;
private StatsdDataFactoryInterface $statsdDataFactory;
private CounterMetric $eventsCounter;
public function __construct(
ConfigFactory $configFactory,
UserOptionsLookup $userOptionsLookup,
StatsdDataFactoryInterface $statsdDataFactory
StatsFactory $statsFactory
) {
$this->config = $configFactory->makeConfig( 'revisionslider' );
$this->userOptionsLookup = $userOptionsLookup;
$this->statsdDataFactory = $statsdDataFactory;
$this->eventsCounter = $statsFactory->getCounter( 'RevisionSlider_events_total' )
->setLabel( 'event', 'n/a' );
}
/**
@ -53,7 +55,9 @@ class RevisionSliderHooks implements DifferenceEngineViewHeaderHook, GetPreferen
return;
}
$this->statsdDataFactory->increment( 'RevisionSlider.event.hookinit' );
$this->eventsCounter->setLabel( 'event', 'hookinit' )
->copyToStatsdAt( 'RevisionSlider.event.hookinit' )
->increment();
$timeOffset = 0;
if ( $this->config->get( MainConfigNames::Localtimezone ) !== null ) {
@ -67,10 +71,14 @@ class RevisionSliderHooks implements DifferenceEngineViewHeaderHook, GetPreferen
$out->addModuleStyles( 'ext.RevisionSlider.lazyCss' );
if ( $autoExpand ) {
$out->addModules( 'ext.RevisionSlider.init' );
$this->statsdDataFactory->increment( 'RevisionSlider.event.load' );
$this->eventsCounter->setLabel( 'event', 'load' )
->copyToStatsdAt( 'RevisionSlider.event.load' )
->increment();
} else {
$out->addModules( 'ext.RevisionSlider.lazyJs' );
$this->statsdDataFactory->increment( 'RevisionSlider.event.lazyload' );
$this->eventsCounter->setLabel( 'event', 'lazyload' )
->copyToStatsdAt( 'RevisionSlider.event.lazyload' )
->increment();
}
$out->addJsConfigVars( 'extRevisionSliderTimeOffset', $timeOffset );
$out->enableOOUI();

4
tests/phpunit/RevisionSliderHooksTest.php
View file

@ -8,7 +8,7 @@ use MediaWiki\Revision\RevisionRecord;
use MediaWiki\Title\Title;
use MediaWiki\User\Options\StaticUserOptionsLookup;
use MediaWiki\User\User;
use Wikimedia\Stats\NullStatsdDataFactory;
use Wikimedia\Stats\StatsFactory;
/**
* @covers \MediaWiki\Extension\RevisionSlider\RevisionSliderHooks
@ -74,7 +74,7 @@ class RevisionSliderHooksTest extends \MediaWikiIntegrationTestCase {
return new RevisionSliderHooks(
$configFactory,
new StaticUserOptionsLookup( [], $options ),
new NullStatsdDataFactory()
StatsFactory::newNull()
);
}