wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-11-23 23:13:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Don't trigger hover or tooltips from a tooltip"

Browse source
This commit is contained in:
jenkins-bot 2023-09-04 09:35:43 +00:00 committed by Gerrit Code Review
parent 77792dfc12 45b68b2942
commit 23b2f811a2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ext.RevisionSlider.RevisionListView.js
View file

@ -143,17 +143,17 @@ $.extend( RevisionListView.prototype, {
* @param {MouseEvent} event
*/
setRevisionHoveredFromMouseEvent: function ( $revisionWrapper, event ) {
if ( !$revisionWrapper.length ) {
if ( !$revisionWrapper.length || $( event.target ).closest( '.mw-revslider-revision-tooltip' ).length ) {
return;
}
this.showTooltip( $revisionWrapper );
const hasMovedTop = event.pageY - $revisionWrapper.offset().top < $revisionWrapper.height() / 2,
isOlderTop = $revisionWrapper.hasClass( 'mw-revslider-revision-older' ) && hasMovedTop,
isNewerBottom = $revisionWrapper.hasClass( 'mw-revslider-revision-newer' ) && !hasMovedTop;
let $neighborRevisionWrapper = $revisionWrapper;
this.showTooltip( $revisionWrapper );
if ( isOlderTop ) {
$neighborRevisionWrapper = $revisionWrapper.prev();
} else if ( isNewerBottom ) {