mediawiki-extensions-Revisi.../modules/ext.RevisionSlider.lazy.js

const Settings = require( 'ext.RevisionSlider.Settings' ),
	autoExpand = new Settings().shouldAutoExpand();

if ( autoExpand ) {
	mw.loader.load( 'ext.RevisionSlider.init' );
} else {
	$( '.mw-revslider-toggle-button' ).on( {
		click: function () {
			mw.loader.load( 'ext.RevisionSlider.init' );
		},
		keypress: function ( event ) {
			if ( event.which === 13 || event.which === 32 ) {
				event.preventDefault();
				$( '.mw-revslider-toggle-button' ).trigger( 'click' );
			}
		}
	} );
}
Migrate JS to ES6 Reintroduces IIFE closures in test files because variables were declared in the global namespace, and "const" now causes hard errors. Bug: T339323 Change-Id: I69e9d7a29591137f185f3e5ab02dea590ec4dff6 2023-06-22 09:41:37 +00:00			`const Settings = require( 'ext.RevisionSlider.Settings' ),`
Don't add keypress handler when not needed I'm not sure why it was done this way. Probably because it doesn't make an actual difference from the user's perspective. My motivation is: When we already called the code that auto-expands the RevisionSlider UI then it doesn't make much sense to give the user a keyypress handler that does the same a second time. Possibly even related to T342556? This patch also contains a few small, unrelated code cleanups. Change-Id: I123e89d9d7dc3b1e33cf43831c679330d9dd1cdd 2023-08-25 14:23:18 +00:00			`autoExpand = new Settings().shouldAutoExpand();`
Lazy load most of the JS With the parent of this commit (current master) Loading the RevisionSlider JS without it expanded increases the request size by roughly 767KB on first request and 242KB on subsequent requests. The large size of the first request is mainly down the to dependancies of the slider. This lazy loading patch means the RevisionSlider JS only causes an increase of 184 KB per request. If the user has the bar expand by default the main JS will be loaded straight away (and the lazy JS will not be). This patch also means that when only the bar is loaded the pin button to set auto expand will not be shown. This will be added once the RevsionSlider is loaded. Bug: T151668 Change-Id: I054a82e9ea2aa89326464632e744497239f7adba 2016-11-23 18:43:31 +00:00
Remove closure wrappers from all JavaScript code These are not needed any more, because the code runs in a seperate scope anyway. Change-Id: I939a06102f194a0c98021accb2f62be73dd0562f 2020-11-18 09:11:12 +00:00			`if ( autoExpand ) {`
			`mw.loader.load( 'ext.RevisionSlider.init' );`
			`} else {`
Don't add keypress handler when not needed I'm not sure why it was done this way. Probably because it doesn't make an actual difference from the user's perspective. My motivation is: When we already called the code that auto-expands the RevisionSlider UI then it doesn't make much sense to give the user a keyypress handler that does the same a second time. Possibly even related to T342556? This patch also contains a few small, unrelated code cleanups. Change-Id: I123e89d9d7dc3b1e33cf43831c679330d9dd1cdd 2023-08-25 14:23:18 +00:00			`$( '.mw-revslider-toggle-button' ).on( {`
			`click: function () {`
Remove closure wrappers from all JavaScript code These are not needed any more, because the code runs in a seperate scope anyway. Change-Id: I939a06102f194a0c98021accb2f62be73dd0562f 2020-11-18 09:11:12 +00:00			`mw.loader.load( 'ext.RevisionSlider.init' );`
Don't add keypress handler when not needed I'm not sure why it was done this way. Probably because it doesn't make an actual difference from the user's perspective. My motivation is: When we already called the code that auto-expands the RevisionSlider UI then it doesn't make much sense to give the user a keyypress handler that does the same a second time. Possibly even related to T342556? This patch also contains a few small, unrelated code cleanups. Change-Id: I123e89d9d7dc3b1e33cf43831c679330d9dd1cdd 2023-08-25 14:23:18 +00:00			`},`
			`keypress: function ( event ) {`
			`if ( event.which === 13 \|\| event.which === 32 ) {`
			`event.preventDefault();`
			`$( '.mw-revslider-toggle-button' ).trigger( 'click' );`
			`}`
Added keypress() to mw-revslider-toggle-button On tapping Enter or Space the Rev-Slider Opens Bug: T199212 Change-Id: I08ab018c3e89d25ab8d4e72963e9cbd4971f7068 2018-08-13 04:42:09 +00:00			`}`
Don't add keypress handler when not needed I'm not sure why it was done this way. Probably because it doesn't make an actual difference from the user's perspective. My motivation is: When we already called the code that auto-expands the RevisionSlider UI then it doesn't make much sense to give the user a keyypress handler that does the same a second time. Possibly even related to T342556? This patch also contains a few small, unrelated code cleanups. Change-Id: I123e89d9d7dc3b1e33cf43831c679330d9dd1cdd 2023-08-25 14:23:18 +00:00			`} );`
Remove closure wrappers from all JavaScript code These are not needed any more, because the code runs in a seperate scope anyway. Change-Id: I939a06102f194a0c98021accb2f62be73dd0562f 2020-11-18 09:11:12 +00:00			`}`