wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2024-12-12 07:25:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Revisi.../tests/browser/features/expand.feature

23 lines
832 B
Gherkin
Raw Normal View History

Do not load RevisionSlider initially, add a button to show/hide it Instead of loading RevisionSlider only add a little button to expand RevisionSlider on top of the diff page. This makes RevisionSlider only steal a bit of space over the diff, and only inserts quite a big slider to users that want to have it visible for the particular diff. API calls are only made once RevisionSlider has been expanded. This is re-submit of b0f229d75f905a9570497dc095b410f20f4b53ae that was reverted in I26427faaa00b38c2aa1377a66224c9062dcca302. Bug: T141871 Change-Id: I879de5774b2cce7b908e73cbbe869fd48d6afa23
2016-08-05 16:14:28 +00:00
@chrome @en.wikipedia.beta.wmflabs.org @firefox @integration
Feature: RevisionSlider expand
Background:
Remove browser tests for beta feature setting The browser tests do not gain very much from the beta feature tests and the default setting having the extension only availible as a beta feature slows down the tests in general. Furthermore removing this will make it easier to let tests pass for the temporary change in the slider logic. Change-Id: I7377a6f11aa103af76d14fea3cbb34572495192a
2017-04-05 09:24:40 +00:00
Given a page with 2 revision(s) exists
Do not load RevisionSlider initially, add a button to show/hide it Instead of loading RevisionSlider only add a little button to expand RevisionSlider on top of the diff page. This makes RevisionSlider only steal a bit of space over the diff, and only inserts quite a big slider to users that want to have it visible for the particular diff. API calls are only made once RevisionSlider has been expanded. This is re-submit of b0f229d75f905a9570497dc095b410f20f4b53ae that was reverted in I26427faaa00b38c2aa1377a66224c9062dcca302. Bug: T141871 Change-Id: I879de5774b2cce7b908e73cbbe869fd48d6afa23
2016-08-05 16:14:28 +00:00
Scenario: RevisionSlider is collapsed initially
Given I am on the diff page
Then There should be a RevisionSlider expand button
And RevisionSlider wrapper should be hidden
Scenario: RevisionSlider loads after expanding
Given I am on the diff page
Refactor expand browsertests - Applied the Given-When-Then rule to scenarios - Added alias for one step for better readability of scenarios Bug: T146276 Change-Id: I08aabda113d6ad9f1bbf06161484143549b13a7c
2016-10-07 14:02:46 +00:00
When I click on the expand button
Do not load RevisionSlider initially, add a button to show/hide it Instead of loading RevisionSlider only add a little button to expand RevisionSlider on top of the diff page. This makes RevisionSlider only steal a bit of space over the diff, and only inserts quite a big slider to users that want to have it visible for the particular diff. API calls are only made once RevisionSlider has been expanded. This is re-submit of b0f229d75f905a9570497dc095b410f20f4b53ae that was reverted in I26427faaa00b38c2aa1377a66224c9062dcca302. Bug: T141871 Change-Id: I879de5774b2cce7b908e73cbbe869fd48d6afa23
2016-08-05 16:14:28 +00:00
Then RevisionSlider wrapper should be visible
And The RevisionSlider has loaded
Scenario: RevisionSlider hides after collapsing
Use cookie to dismiss help dialog and fix failing browser tests I have seen this failing: https://integration.wikimedia.org/ci/job/mwext-mw-selenium-jessie/9255/console The idea is to pre-set this cookie so the help dialog never shows up in the first place. The tests do not need to look for the element, click it, wait for the dialog to close. This should even speed up the browser tests, I believe. Also this adjustes waiting conditions in several places to address timing issues with failing browser tests. Since these tests should be replaced by Node.js on the long run I added "sleep" in the cases although it's not recommended. Change-Id: Ida381faa390aa62ebaadd3713864676be80abd51
2018-06-29 07:49:09 +00:00
Given I am on the diff page and disabled the help dialog
Refactor expand browsertests - Applied the Given-When-Then rule to scenarios - Added alias for one step for better readability of scenarios Bug: T146276 Change-Id: I08aabda113d6ad9f1bbf06161484143549b13a7c
2016-10-07 14:02:46 +00:00
When I click on the expand button
And I wait until the RevisionSlider has loaded
Do not load RevisionSlider initially, add a button to show/hide it Instead of loading RevisionSlider only add a little button to expand RevisionSlider on top of the diff page. This makes RevisionSlider only steal a bit of space over the diff, and only inserts quite a big slider to users that want to have it visible for the particular diff. API calls are only made once RevisionSlider has been expanded. This is re-submit of b0f229d75f905a9570497dc095b410f20f4b53ae that was reverted in I26427faaa00b38c2aa1377a66224c9062dcca302. Bug: T141871 Change-Id: I879de5774b2cce7b908e73cbbe869fd48d6afa23
2016-08-05 16:14:28 +00:00
And I click on the expand button
Then RevisionSlider wrapper should be hidden
Reference in a new issue Copy permalink