wikimedia/mediawiki-extensions-RevisionSlider
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RevisionSlider synced 2025-01-07 11:24:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Revisi.../tests/RevisionSlider.RevisionList.test.js

28 lines
720 B
JavaScript
Raw Normal View History

Create Slider module. * threw out most of the things from init.js * turned Slider + View into respective modules * pointers should remember position (except on page load) and correctly slide back to their position/to the side Some things still need testing and refactoring. Addshore: - CS fixes and comment out current failing tests Bug: T134395 Change-Id: I78a7095e1d9902314163b1443448f47ef0484d4e
2016-05-10 12:42:05 +00:00
( function ( mw ) {
Improve SliderView rendering tests Current rendering test passes but not really because test results meet expectations but rather by accident. Test revisions lacked ids, and current way of rendering revision made all revision bars have id equal to "undefined" string. That made test pass, although it is not what is expected (we expect three revisions in tests but not that three revisions have the same id, and each of them gets a pointer assigned to - the might look interesting in the browser, though). Also the test will fail as soon as the way of rendering revisions is switched to standard use of jquery's attr() instead of handcrafting the HTML in the RevisionListView class. This patch adds missing IDs to test Revisions where needed, and also set config vars that are required to render Slider properly. This also adds tests for cases where the exception is thrown. This also makes RevisionList initialization consistent. RevisionList expect to receive an array of revision data in a format that API returns. Tests provided arrays of Revision objects instead. That also works with a difference that API-like format uses "revid" as a field containing revision ID, while Revision objects use a field named "id". The way RevisionList was used in tests actually lead to have each revision initialized twice, and on the second initialization it lost its ID (due to field name difference). This changes test to provide a API-like array instead of arrays of Revision objects to RevisionList. Change-Id: I147270f28381038d05f8bcfd2317e8c269b2e458
2016-05-31 10:00:07 +00:00
var RevisionList = mw.libs.revisionSlider.RevisionList;
Create Slider module. * threw out most of the things from init.js * turned Slider + View into respective modules * pointers should remember position (except on page load) and correctly slide back to their position/to the side Some things still need testing and refactoring. Addshore: - CS fixes and comment out current failing tests Bug: T134395 Change-Id: I78a7095e1d9902314163b1443448f47ef0484d4e
2016-05-10 12:42:05 +00:00
QUnit.module( 'ext.RevisionSlider.RevisionList' );
QUnit.test( 'Find biggest Revision', function ( assert ) {
var revs = new RevisionList( [
Improve SliderView rendering tests Current rendering test passes but not really because test results meet expectations but rather by accident. Test revisions lacked ids, and current way of rendering revision made all revision bars have id equal to "undefined" string. That made test pass, although it is not what is expected (we expect three revisions in tests but not that three revisions have the same id, and each of them gets a pointer assigned to - the might look interesting in the browser, though). Also the test will fail as soon as the way of rendering revisions is switched to standard use of jquery's attr() instead of handcrafting the HTML in the RevisionListView class. This patch adds missing IDs to test Revisions where needed, and also set config vars that are required to render Slider properly. This also adds tests for cases where the exception is thrown. This also makes RevisionList initialization consistent. RevisionList expect to receive an array of revision data in a format that API returns. Tests provided arrays of Revision objects instead. That also works with a difference that API-like format uses "revid" as a field containing revision ID, while Revision objects use a field named "id". The way RevisionList was used in tests actually lead to have each revision initialized twice, and on the second initialization it lost its ID (due to field name difference). This changes test to provide a API-like array instead of arrays of Revision objects to RevisionList. Change-Id: I147270f28381038d05f8bcfd2317e8c269b2e458
2016-05-31 10:00:07 +00:00
{ size: 5 },
{ size: 21 },
{ size: 13 }
Create Slider module. * threw out most of the things from init.js * turned Slider + View into respective modules * pointers should remember position (except on page load) and correctly slide back to their position/to the side Some things still need testing and refactoring. Addshore: - CS fixes and comment out current failing tests Bug: T134395 Change-Id: I78a7095e1d9902314163b1443448f47ef0484d4e
2016-05-10 12:42:05 +00:00
] );
assert.equal( revs.getBiggestChangeSize(), 16 );
} );
Adds the missing first revision to the slider. The first revision was previously not included because revision size was calculated by subtracting the size in bytes of a revision from the size of the previous revision which lead to a problem with the first revision. The first revision's relative size is now equal to its actual size. Bug: T135003 Change-Id: I71441ed33673b06407be0fc566c96c3955dddbf9
2016-05-12 13:52:54 +00:00
QUnit.test( 'calculate relative size on init', function ( assert ) {
var revs = new RevisionList( [
Improve SliderView rendering tests Current rendering test passes but not really because test results meet expectations but rather by accident. Test revisions lacked ids, and current way of rendering revision made all revision bars have id equal to "undefined" string. That made test pass, although it is not what is expected (we expect three revisions in tests but not that three revisions have the same id, and each of them gets a pointer assigned to - the might look interesting in the browser, though). Also the test will fail as soon as the way of rendering revisions is switched to standard use of jquery's attr() instead of handcrafting the HTML in the RevisionListView class. This patch adds missing IDs to test Revisions where needed, and also set config vars that are required to render Slider properly. This also adds tests for cases where the exception is thrown. This also makes RevisionList initialization consistent. RevisionList expect to receive an array of revision data in a format that API returns. Tests provided arrays of Revision objects instead. That also works with a difference that API-like format uses "revid" as a field containing revision ID, while Revision objects use a field named "id". The way RevisionList was used in tests actually lead to have each revision initialized twice, and on the second initialization it lost its ID (due to field name difference). This changes test to provide a API-like array instead of arrays of Revision objects to RevisionList. Change-Id: I147270f28381038d05f8bcfd2317e8c269b2e458
2016-05-31 10:00:07 +00:00
{ size: 5 },
{ size: 21 },
{ size: 13 }
Adds the missing first revision to the slider. The first revision was previously not included because revision size was calculated by subtracting the size in bytes of a revision from the size of the previous revision which lead to a problem with the first revision. The first revision's relative size is now equal to its actual size. Bug: T135003 Change-Id: I71441ed33673b06407be0fc566c96c3955dddbf9
2016-05-12 13:52:54 +00:00
] );
assert.equal( revs.getRevisions()[ 0 ].getRelativeSize(), 5 );
assert.equal( revs.getRevisions()[ 1 ].getRelativeSize(), 16 );
assert.equal( revs.getRevisions()[ 2 ].getRelativeSize(), -8 );
} );
Create Slider module. * threw out most of the things from init.js * turned Slider + View into respective modules * pointers should remember position (except on page load) and correctly slide back to their position/to the side Some things still need testing and refactoring. Addshore: - CS fixes and comment out current failing tests Bug: T134395 Change-Id: I78a7095e1d9902314163b1443448f47ef0484d4e
2016-05-10 12:42:05 +00:00
} )( mediaWiki );
Reference in a new issue Copy permalink