mediawiki-extensions-Revisi.../tests/qunit/RevisionSlider.Pointer.test.js

( function ( mw ) {
	var Pointer = mw.libs.revisionSlider.Pointer;

	QUnit.module( 'ext.RevisionSlider.Pointer' );

	QUnit.test( 'Initialize Pointer', function ( assert ) {
		assert.ok( ( new Pointer( 'mw-revslider-pointer' ) ).getView().render().hasClass( 'mw-revslider-pointer' ) );
	} );

	QUnit.test( 'Set and get position', function ( assert ) {
		var pointer = new Pointer(),
			pos = 42;

		pointer.setPosition( pos );
		assert.equal( pointer.getPosition(), pos );
	} );

}( mediaWiki ) );
Create Pointer module. This creates a module for the draggable pointers for the RevisionSlider mainly to encapsulate both the pointers' state and their HTML code. Some animation methods such as slideToSide and slideToPosition that are still flying around in init.js weren't added to the module since I thought they should be part of the not yet existing Slider module. Change-Id: I1292bfb0bbd68f8d2de04b3b5e5f3133ec6363b8 2016-05-03 11:26:42 +00:00			`( function ( mw ) {`
			`var Pointer = mw.libs.revisionSlider.Pointer;`

Fix Pointer and PointerView tests Initialization tests for both classes were checking if the rendered view or the view related to the pointer contained an element with particular CSS class. The structure of the view has apparently changed as it no longer contains an element with a particular class but the view's DIV itself get the CSS class. Assertion in tests has been wrong and did not catch the change (in particular, apparently jQuery's find returned an empty object which does not evaluate to false in qunit assertion). This changes initialization tests to check the CSS class of the view element. It also reflects the removal of left/right pointer distinction made in I9d56314ea4cf46402df56e0a038bfb965521896. This also rename both test modules as they had misleading names. Change-Id: I5956022af332c9915e983a020732edbe1dd75aef 2016-05-17 11:46:48 +00:00			`QUnit.module( 'ext.RevisionSlider.Pointer' );`
Create Pointer module. This creates a module for the draggable pointers for the RevisionSlider mainly to encapsulate both the pointers' state and their HTML code. Some animation methods such as slideToSide and slideToPosition that are still flying around in init.js weren't added to the module since I thought they should be part of the not yet existing Slider module. Change-Id: I1292bfb0bbd68f8d2de04b3b5e5f3133ec6363b8 2016-05-03 11:26:42 +00:00
			`QUnit.test( 'Initialize Pointer', function ( assert ) {`
Prefix all classes and IDs with mw-revslider Bug: T139105 Change-Id: Ia92396ec4f8acea39398173c81842d66257dc519 2016-07-01 10:13:53 +00:00			`assert.ok( ( new Pointer( 'mw-revslider-pointer' ) ).getView().render().hasClass( 'mw-revslider-pointer' ) );`
Create Pointer module. This creates a module for the draggable pointers for the RevisionSlider mainly to encapsulate both the pointers' state and their HTML code. Some animation methods such as slideToSide and slideToPosition that are still flying around in init.js weren't added to the module since I thought they should be part of the not yet existing Slider module. Change-Id: I1292bfb0bbd68f8d2de04b3b5e5f3133ec6363b8 2016-05-03 11:26:42 +00:00			`} );`

			`QUnit.test( 'Set and get position', function ( assert ) {`
			`var pointer = new Pointer(),`
			`pos = 42;`

			`pointer.setPosition( pos );`
			`assert.equal( pointer.getPosition(), pos );`
			`} );`

Add eslint, to be used instead of jscs and/or jshint First I jumped on replacing both jscs and jshint with eslint but it might be premature decision. Although linting with eslint is possible (like in there is wikimedia config for eslint) it is still not clear should it But in case the change happens we will be ready. Apart from config stuff this changes few bits spotted by eslint: improves some indentation, removes weird spaces, completes some doc blocks, changes IIFE forms in tests. These changes do not seem controversial. Change-Id: I9f8bf0f5745da8e662685f4cd879ea4baa609c01 2016-09-01 11:17:47 +00:00			`}( mediaWiki ) );`