wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-11-23 22:33:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Updating mediawiki/mediawiki-phan-config to 0.8.0

Browse source 
Bug: T235049
Change-Id: I752c89cd13ecc55cbbcbe9c3b94c862c096daf87
This commit is contained in:
Umherirrender 2019-11-06 19:46:03 +01:00
parent 8d9ef58422
commit dab839001a
3 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
composer.json
View file

@ -4,7 +4,7 @@
"mediawiki/mediawiki-codesniffer": "26.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.3.1",
"mediawiki/mediawiki-phan-config": "0.6.1"
"mediawiki/mediawiki-phan-config": "0.8.0"
},
"scripts": {
"fix": [

6
maintenance/replaceAll.php
View file

@ -399,10 +399,8 @@ EOF;
continue;
}
if (
!$this->shouldContinueByDefault() &&
$this->listTitles( $titles, $target, $replacement, $useRegex, $this->rename )
) {
if ( !$this->shouldContinueByDefault() ) {
$this->listTitles( $titles, $target, $replacement, $useRegex, $this->rename );
if ( !$this->getReply( 'Replace instances on these pages?' ) ) {
return;
}

6
src/ReplaceTextJob.php
View file

@ -87,12 +87,6 @@ class ReplaceTextJob extends Job {
return false;
}
$wikiPage = new WikiPage( $this->title );
// Is this check necessary?
if ( !$wikiPage ) {
$this->error =
'replaceText: Wiki page not found for "' . $this->title->getPrefixedDBkey() . '."';
return false;
}
$wikiPageContent = $wikiPage->getContent();
if ( is_null( $wikiPageContent ) ) {
$this->error =