wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-11-24 06:43:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Check for invalid new titles"

Browse source
This commit is contained in:
jenkins-bot 2022-09-08 13:32:34 +00:00 committed by Gerrit Code Review
parent bf60096c5f e95564bcdc
commit cb08a9a768
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/SpecialReplaceText.php
View file

@ -426,7 +426,7 @@ class SpecialReplaceText extends SpecialPage {
foreach ( $res as $row ) {
$title = Title::makeTitleSafe( $row->page_namespace, $row->page_title );
if ( $title == null ) {
if ( !$title ) {
continue;
}
@ -436,6 +436,11 @@ class SpecialReplaceText extends SpecialPage {
$this->replacement,
$this->use_regex
);
if ( !$new_title ) {
// New title is not valid because it contains invalid characters.
$unmoveable_titles[] = $title;
continue;
}
$mvPage = $this->movePageFactory->newMovePage( $title, $new_title );
$moveStatus = $mvPage->isValidMove();