build: Updating mediawiki/mediawiki-codesniffer to 24.0.0

The following sniffs are failing and were disabled:
* MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgContLang

Change-Id: I56fb225b2f158ed69fed80fe9a1a2066f407064f
This commit is contained in:
libraryupgrader 2019-02-07 03:44:53 +00:00
parent 79655e5aa3
commit bf538064a8
3 changed files with 4 additions and 3 deletions

View file

@ -1,6 +1,7 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgContLang" />
<exclude name="Squiz.PHP.NonExecutableCode.Unreachable" /> <exclude name="Squiz.PHP.NonExecutableCode.Unreachable" />
<exclude name="Squiz.Scope.MethodScope.Missing" /> <exclude name="Squiz.Scope.MethodScope.Missing" />
</rule> </rule>

View file

@ -1,7 +1,7 @@
{ {
"require-dev": { "require-dev": {
"jakub-onderka/php-parallel-lint": "1.0.0", "jakub-onderka/php-parallel-lint": "1.0.0",
"mediawiki/mediawiki-codesniffer": "23.0.0", "mediawiki/mediawiki-codesniffer": "24.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2", "jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.3.1", "mediawiki/minus-x": "0.3.1",
"mediawiki/mediawiki-phan-config": "0.3.0" "mediawiki/mediawiki-phan-config": "0.3.0"

View file

@ -152,7 +152,7 @@ class SpecialReplaceText extends SpecialPage {
$this->showForm( 'replacetext_nonamespace' ); $this->showForm( 'replacetext_nonamespace' );
return; return;
} }
if ( ! $this->edit_pages && ! $this->move_pages ) { if ( !$this->edit_pages && !$this->move_pages ) {
$this->showForm( 'replacetext_editormove' ); $this->showForm( 'replacetext_editormove' );
return; return;
} }
@ -205,7 +205,7 @@ class SpecialReplaceText extends SpecialPage {
); );
} else { } else {
$warning_msg = $this->getAnyWarningMessageBeforeReplace( $titles_for_edit, $titles_for_move ); $warning_msg = $this->getAnyWarningMessageBeforeReplace( $titles_for_edit, $titles_for_move );
if ( ! is_null( $warning_msg ) ) { if ( !is_null( $warning_msg ) ) {
$out->addWikiText( "<div class=\"errorbox\">$warning_msg</div><br clear=\"both\" />" ); $out->addWikiText( "<div class=\"errorbox\">$warning_msg</div><br clear=\"both\" />" );
} }