wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-11-23 14:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

SpecialReplaceText: Remove redundant white-space: nowrap inline style

Browse source 
The inline style on the `<td>` around namespace checkboxes is
redundant, because ext.ReplaceTextStyles.less already sets the same
style on the same element via `.ext-replacetext-searchoptions td`.

While at it, simplify that CSS selector by removing needless
indirection and specificity via `table`.

Change-Id: I59bad7592b7106dbf335298ff4c6b017c2bca855
This commit is contained in:
Timo Tijhof 2024-03-26 20:01:01 -07:00 committed by Krinkle
parent 886c0a21db
commit bb6a92ad23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
resources/ext.ReplaceTextStyles.less
View file

@ -25,11 +25,11 @@
float: left;
margin: 0 1em 0 0;
border-collapse: collapse;
}
td {
padding: 0 1em 0 0;
white-space: nowrap;
}
td {
padding: 0 1em 0 0;
white-space: nowrap;
}
.ext-replacetext-divider {

2
src/SpecialReplaceText.php
View file

@ -782,7 +782,7 @@ class SpecialReplaceText extends SpecialPage {
$name = $this->msg( 'blanknamespace' )->text();
}
$id = "mw-search-ns{$ns}";
$rows[$subj] .= Html::openElement( 'td', [ 'style' => 'white-space: nowrap' ] ) .
$rows[$subj] .= Html::openElement( 'td' ) .
Html::input( "ns{$ns}", '1', 'checkbox', [ 'id' => $id, 'checked' => in_array( $ns, $namespaces ) ] ) .
' ' . Html::label( $name, $id ) .
Html::closeElement( 'td' ) . "\n";