wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-09-23 10:19:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

replaceAll.php: Replace get_class with instanceof

Browse source 
The User class was namespaced in 1d0b7ae1,
checking class names as string is broken, use instanceof.
There are no subclasses of User class to ignore at this point.

Also use User::getName instead of implicit User::__toString

Change-Id: I8b9f73609a7ef9f781c8a5ae27e00d612d33ee4f
This commit is contained in:
Umherirrender 2024-01-05 21:26:44 +01:00
parent 464311b4bc
commit a14f9f6b5b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
maintenance/replaceAll.php
View file

@ -30,6 +30,7 @@
namespace MediaWiki\Extension\ReplaceText;
use Maintenance;
use MediaWiki\User\User;
use MWException;
$IP = getenv( 'MW_INSTALL_PATH' ) ?: __DIR__ . '/../../..';
@ -112,7 +113,7 @@ class ReplaceAll extends Maintenance {
$userFactory->newFromId( $userReplacing ) :
$userFactory->newFromName( $userReplacing );
if ( get_class( $user ) !== 'User' ) {
if ( !$user instanceof User ) {
$this->fatalError(
"Couldn't translate '$userReplacing' to a user."
);
@ -437,7 +438,7 @@ EOF;
$this->botEdit = true;
}
if ( !$this->getReply(
"Attribute changes to the user '{$this->user}'?$comment"
"Attribute changes to the user '{$this->user->getName()}'?$comment"
) ) {
return;
}