wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-09-23 10:19:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Inject service ReadOnlyMode

Browse source 
Also reuse local variable $services for
MediaWikiServices::getInstance() in Job.php.

Change-Id: I0364c64aaf52e229f3e2a2c73c7d4716ec566fae
This commit is contained in:
Fomafix 2023-06-16 22:24:49 +00:00
parent 986b51e5a2
commit 772a4f5642
3 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extension.json
View file

@ -31,6 +31,7 @@
"LinkRenderer",
"MovePageFactory",
"NamespaceInfo",
"ReadOnlyMode",
"SearchEngineConfig",
"SlotRoleStore",
"UserFactory",

2
src/Job.php
View file

@ -101,7 +101,7 @@ class Job extends JobParent {
$services->getWatchlistManager()->addWatch( $current_user, $new_title );
}
} else {
$wikiPage = MediaWikiServices::getInstance()->getWikiPageFactory()->newFromTitle( $this->title );
$wikiPage = $services->getWikiPageFactory()->newFromTitle( $this->title );
$latestRevision = $wikiPage->getRevisionRecord();
if ( $latestRevision === null ) {

13
src/SpecialReplaceText.php
View file

@ -25,7 +25,6 @@ use JobQueueGroup;
use Language;
use MediaWiki\HookContainer\HookContainer;
use MediaWiki\Linker\LinkRenderer;
use MediaWiki\MediaWikiServices;
use MediaWiki\Page\MovePageFactory;
use MediaWiki\Revision\SlotRecord;
use MediaWiki\Storage\NameTableStore;
@ -37,6 +36,7 @@ use PermissionsError;
use SearchEngineConfig;
use SpecialPage;
use Title;
use Wikimedia\Rdbms\ReadOnlyMode;
use Xml;
class SpecialReplaceText extends SpecialPage {
@ -69,6 +69,9 @@ class SpecialReplaceText extends SpecialPage {
/** @var NamespaceInfo */
private $namespaceInfo;
/** @var ReadOnlyMode */
private $readOnlyMode;
/** @var SearchEngineConfig */
private $searchEngineConfig;
@ -88,6 +91,7 @@ class SpecialReplaceText extends SpecialPage {
* @param LinkRenderer $linkRenderer
* @param MovePageFactory $movePageFactory
* @param NamespaceInfo $namespaceInfo
* @param ReadOnlyMode $readOnlyMode
* @param SearchEngineConfig $searchEngineConfig
* @param NameTableStore $slotRoleStore
* @param UserFactory $userFactory
@ -100,6 +104,7 @@ class SpecialReplaceText extends SpecialPage {
LinkRenderer $linkRenderer,
MovePageFactory $movePageFactory,
NamespaceInfo $namespaceInfo,
ReadOnlyMode $readOnlyMode,
SearchEngineConfig $searchEngineConfig,
NameTableStore $slotRoleStore,
UserFactory $userFactory,
@ -112,6 +117,7 @@ class SpecialReplaceText extends SpecialPage {
$this->linkRenderer = $linkRenderer;
$this->movePageFactory = $movePageFactory;
$this->namespaceInfo = $namespaceInfo;
$this->readOnlyMode = $readOnlyMode;
$this->searchEngineConfig = $searchEngineConfig;
$this->slotRoleStore = $slotRoleStore;
$this->userFactory = $userFactory;
@ -144,9 +150,8 @@ class SpecialReplaceText extends SpecialPage {
$out = $this->getOutput();
$readOnlyMode = MediaWikiServices::getInstance()->getReadOnlyMode();
if ( $readOnlyMode->isReadOnly() ) {
$permissionErrors = [ [ 'readonlytext', [ $readOnlyMode->getReason() ] ] ];
if ( $this->readOnlyMode->isReadOnly() ) {
$permissionErrors = [ [ 'readonlytext', [ $this->readOnlyMode->getReason() ] ] ];
$out->setPageTitle( $this->msg( 'badaccess' )->text() );
$out->addWikiTextAsInterface( $out->formatPermissionsErrorMessage( $permissionErrors, 'replacetext' ) );
return;