wikimedia/mediawiki-extensions-ReplaceText
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ReplaceText synced 2024-11-23 22:33:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added CSRF check.

Browse source 
Bug: T191546
Change-Id: Ib6a951152db222b6289b9b8d09608dfe75ed2de2
This commit is contained in:
Cindy Cicalese 2018-04-10 21:25:57 +00:00 committed by Brian Wolff
parent b02d10f2e1
commit 1d68a5f3f9
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
SpecialReplaceText.php
View file

@ -58,13 +58,19 @@ class SpecialReplaceText extends SpecialPage {
} }
if ( $request->getCheck( 'replace' ) ) { if ( $request->getCheck( 'replace' ) ) {
// check for CSRF
$user = $this->getUser();
if ( !$user->matchEditToken( $request->getVal( 'token' ) ) ) {
$out->addWikiMsg( 'sessionfailure' );
return;
}
global $wgReplaceTextUser; global $wgReplaceTextUser;
$replacement_params = array(); $replacement_params = array();
if ( $wgReplaceTextUser != null ) { if ( $wgReplaceTextUser != null ) {
$user = User::newFromName( $wgReplaceTextUser ); $user = User::newFromName( $wgReplaceTextUser );
} else {
$user = $this->getUser();
} }
$replacement_params['user_id'] = $user->getId(); $replacement_params['user_id'] = $user->getId();
$replacement_params['target_str'] = $this->target; $replacement_params['target_str'] = $this->target;
@ -117,6 +123,14 @@ class SpecialReplaceText extends SpecialPage {
wfProfileOut( __METHOD__ ); wfProfileOut( __METHOD__ );
return; return;
} elseif ( $request->getCheck( 'target' ) ) { // very long elseif, look for "end elseif" } elseif ( $request->getCheck( 'target' ) ) { // very long elseif, look for "end elseif"
// check for CSRF
$user = $this->getUser();
if ( !$user->matchEditToken( $request->getVal( 'token' ) ) ) {
$out->addWikiMsg( 'sessionfailure' );
return;
}
// first, check that at least one namespace has been // first, check that at least one namespace has been
// picked, and that either editing or moving pages // picked, and that either editing or moving pages
// has been selected // has been selected
@ -293,6 +307,7 @@ class SpecialReplaceText extends SpecialPage {
) . "\n" . ) . "\n" .
Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) . Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) .
Html::hidden( 'continue', 1 ) Html::hidden( 'continue', 1 )
Html::hidden( 'token', $out->getUser()->getEditToken() )
); );
if ( is_null( $warning_msg ) ) { if ( is_null( $warning_msg ) ) {
$out->addWikiMsg( 'replacetext_docu' ); $out->addWikiMsg( 'replacetext_docu' );
@ -472,6 +487,7 @@ class SpecialReplaceText extends SpecialPage {
Html::hidden( 'move_pages', $this->move_pages ) . Html::hidden( 'move_pages', $this->move_pages ) .
Html::hidden( 'edit_pages', $this->edit_pages ) . Html::hidden( 'edit_pages', $this->edit_pages ) .
Html::hidden( 'replace', 1 ) Html::hidden( 'replace', 1 )
Html::hidden( 'token', $out->getUser()->getEditToken() )
); );
foreach ( $this->selected_namespaces as $ns ) { foreach ( $this->selected_namespaces as $ns ) {