mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/RelatedArticles
synced 2024-12-18 19:10:54 +00:00
e5431a1c0b
We currently require support for IntersectionObserver. which is supported on Edge >= 15 (15 has partial support), Firefox >55, Chrome >58, Safari 12.1, Opera >=38, iOS Safari >=12.2, Android 100 Full ES6 is supported in Edge >=15, Firefox >=54, Chrome >=51, Safari >=10, Opera >=38, iOS Safari >=10, so such a change would only drop support for Edge 15 and Firefox 54. CSS.escape is guaranteed in all these browsers according to caniuse, with the only discrepancy being the Edge browser (versions 16-18) so it is also suggested we remove support for those browsers. Firefox 54 accounts for 0.0026% of page views Edge 15-18 accounts for 0.069% of page views Bug: T306355 Change-Id: Id2987e3456607b610c38da9ee157a026d1d00ada
128 lines
4.4 KiB
JavaScript
128 lines
4.4 KiB
JavaScript
( function () {
|
|
const RelatedPagesGateway = require( '../../resources/ext.relatedArticles.readMore.bootstrap/RelatedPagesGateway.js' ),
|
|
lotsaRelatedPages = [ 'A', 'B', 'C', 'D', 'E', 'F' ],
|
|
relatedPages = {
|
|
query: {
|
|
pages: [
|
|
{
|
|
pageid: 123,
|
|
title: 'Oh noes',
|
|
ns: 0,
|
|
thumbnail: {
|
|
source: 'http://placehold.it/200x100'
|
|
}
|
|
}
|
|
]
|
|
}
|
|
},
|
|
emptyRelatedPages = {
|
|
query: {
|
|
pages: []
|
|
}
|
|
};
|
|
|
|
QUnit.module( 'ext.relatedArticles.gateway', {
|
|
beforeEach: function () {
|
|
this.api = new mw.Api();
|
|
}
|
|
} );
|
|
|
|
QUnit.test( 'Returns an array with the results when api responds', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', null, true );
|
|
this.sandbox.stub( this.api, 'get' ).returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function ( results ) {
|
|
assert.ok( Array.isArray( results ), 'Results must be an array' );
|
|
assert.strictEqual( results[ 0 ].title, 'Oh noes' );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Empty related pages is handled fine.', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', null, true );
|
|
this.sandbox.stub( this.api, 'get' ).returns( $.Deferred().resolve( emptyRelatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function ( results ) {
|
|
assert.ok( Array.isArray( results ), 'Results must be an array' );
|
|
assert.strictEqual( results.length, 0 );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Empty related pages with no cirrus search is handled fine. No API request.', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', [], false ),
|
|
spy = this.sandbox.stub( this.api, 'get' ).returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function ( results ) {
|
|
assert.ok( Array.isArray( results ), 'Results must be an array' );
|
|
assert.notOk( spy.called, 'API is not invoked' );
|
|
assert.strictEqual( results.length, 0 );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Related pages from editor curated content', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', [ { title: 1 } ], false );
|
|
this.sandbox.stub( this.api, 'get' ).returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function ( results ) {
|
|
assert.strictEqual( results.length, 1,
|
|
'API still hit despite cirrus being disabled.' );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'When limit is higher than number of cards, no limit is enforced.', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', lotsaRelatedPages, true ),
|
|
// needed to get page images etc..
|
|
stub = this.sandbox.stub( this.api, 'get' )
|
|
.returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 20 ).then( function () {
|
|
assert.strictEqual( stub.args[ 0 ][ 0 ].titles.length, lotsaRelatedPages.length );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'When limit is 2, results are restricted.', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', lotsaRelatedPages, true ),
|
|
// needed to get page images etc..
|
|
stub = this.sandbox.stub( this.api, 'get' )
|
|
.returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 2 ).then( function () {
|
|
assert.strictEqual( stub.args[ 0 ][ 0 ].titles.length, 2 );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'What if editor curated pages is undefined?', function ( assert ) {
|
|
const gateway = new RelatedPagesGateway( this.api, 'Foo', undefined, true );
|
|
// needed to get page images etc..
|
|
this.sandbox.stub( this.api, 'get' )
|
|
.returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function ( results ) {
|
|
assert.ok( Array.isArray( results ), 'Results must be an array' );
|
|
assert.strictEqual( results.length, 1, 'API is invoked to source articles.' );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Ignore related pages from editor curated content', function ( assert ) {
|
|
const wgRelatedArticles = [
|
|
'Bar',
|
|
'Baz',
|
|
'Qux'
|
|
],
|
|
gateway = new RelatedPagesGateway( this.api, 'Foo', wgRelatedArticles, true, true );
|
|
|
|
const spy = this.sandbox.stub( this.api, 'get' )
|
|
.returns( $.Deferred().resolve( relatedPages ) );
|
|
|
|
return gateway.getForCurrentPage( 1 ).then( function () {
|
|
const parameters = spy.lastCall.args[ 0 ];
|
|
|
|
assert.strictEqual(
|
|
parameters.generator,
|
|
'search',
|
|
'it should hit the CirrusSearch API even though wgRelatedArticles is non-empty'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
}() );
|