Commit graph

16 commits

Author SHA1 Message Date
jdlrobson dbb73c389d Remove Related Articles from desktop beta features
This change removes RelatedArticles from beta features.
It repurposes the BlacklistSkins config to be a whitelist that describes
when related pages should be shown in the footer.

To avoid enabling related pages on desktop, this depends on a config
change that makes use of the new configuration option.

Simplify browser tests to reflect the new status quo.

Bug: T146436
Bug: T160076
Depends-On: I522e0182d1c3d9261bd0561c3ec0c789b6431c7a
Change-Id: I84da1fb33a901a6365375d00d192af35422ff0b0
2017-04-04 23:01:36 +00:00
jdlrobson 0e5eef27ce Don't run the test for minerva stable against the beta cluster
On the beta cluster, the browser test should pass.
Add a new test to reflect the two different states.

Bug: T157165
Change-Id: I2a777436dfa3a14d58855449c39cc144b7149a62
2017-02-03 12:23:56 -08:00
jdlrobson c6bc8f804d Update browser test to run on desktop
This previously passed with a false positive as it replicated
the scenario `ReadMore is not present in minerva stable` by running
on the mobile domain.

This change makes it run on the desktop domain and pass (it now
fails given it runs on Minerva skin)

Bug: T157165
Change-Id: Idb2002b0f2d378cc0b6df73ad1381bfee32448c9
2017-02-03 12:22:30 -08:00
Baha 1bc4b5c1b3 Fix browser tests
The ReadMore checkbox on the beta preferences page doesn't have an ID
anymore. It has a name though, which is used from now on.

The regression was introduced in I8636f32330e23814ba3b4c0f5e22e55aaf77883e.

Bug: T148856
Change-Id: Ieb20c8d9e97d53e6afae3a9fc99ce4dea471b0b5
2016-10-24 15:27:53 -04:00
jenkins-bot ec0fbca920 Merge "Allow blacklisting skins for showing ReadMore in footer" 2016-09-26 15:31:04 +00:00
Baha 9c1404ce99 Allow blacklisting skins for showing ReadMore in footer
Introduce a new config variable `RelatedArticlesFooterBlacklistedSkins`
to control skins that are allowed to show ReadMore in the footer.
As before Minerva beta mode is always allowed to show.

Depends-on: I366c8656a0f14a7069053b2e6199caac20471ea4
Depends-on: Ie4ac3c11e81eeea9f5b4a7161a64477cb5d60f07
Bug: T144047
Change-Id: I1663ab25083d9d907f288e60d506831bebb67945
2016-09-26 15:26:03 +00:00
Željko Filipin 316073e6ff Fix MediawikiApi::HttpError in Selenium tests
Use https (instead of http) in mediawiki_url environment variable.

Bug: T145799
Change-Id: Ie4d7188a2f3a11f1eaa5163ffd83544e9828e136
2016-09-16 17:02:14 +02:00
jdlrobson f09f7a717d Beta should be available to test suite.
This old classic returns again.
A browser test fails when this is not enabled as it asserts that
the user is in beta.

Bug: T120715
Change-Id: I2c5339ba959318a3b995a28e22f3df375ae53103
2016-09-12 21:33:58 +00:00
Željko Filipin be874d472e Migration of browsertests* Jenkins jobs to selenium* jobs
selenium* jobs are a new way of running Ruby based Selenium tests. The
jobs are triggered daily.

Bug: T128190
Change-Id: I02fc3e8542d732ca728f47316a8e183ed28744e7
2016-04-25 19:35:20 +02:00
Željko Filipin b272dc6932 Fix mobile Selenium Jenkins job
Until T128190 is resolved, we can not run both mobile and desktop job
daily. Since there are 3 mobile and only 1 desktop scenario, run mobile
job until running desktop jobs is possible.

Bug: T128084
Change-Id: I13eba1c2a4f33f8e88c8bc1a000914e65322b9cc
2016-03-02 12:25:52 +01:00
Željko Filipin 3ca8ef02ad Fixed Selenium tests
Tests now run fine on my local machine and at beta cluster. Please
notice that the first three scenarios run at mobile site, and the fourth
one runs at desktop site.

Bug: T120715
Change-Id: Ib57f48b01d909915ae44976aa51824b4530ffffc
2016-02-13 01:52:28 +00:00
Željko Filipin 33abf32c8c Fixed failing Selenium Jenkins job
The job requires features/scenarios tagged with environment
(@en.m.wikipedia.beta.wmflabs.org) and browser (@chrome) to run
properly.

I did not tag the last scenario, since it failed.

Bug: T126589
Change-Id: Ib99c50657f7a68d0b00048aac96c2f2892e89713
2016-02-11 11:47:04 +01:00
Antoine Musso d8b773f9a4 Rake entry point and rubocop fix up
Introduce the rake test entry point which is invoked by CI.

Add a basic rubocop configuration based on
https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby

Fix up a few ruby issues.

Bug: T120715
Change-Id: I3df0a3b13155259ec6cb5010e7aaa3bf9aa7b230
2016-01-06 16:57:22 +01:00
Baha f19aee12b8 Add Gemfile
mediawiki_selenium 1.4 or greater is need for running browser tests.

Bug: T120715
Change-Id: If5bf9dcc7310896b8d8b218d636952c344a2a105
2015-12-28 15:54:25 +01:00
jdlrobson 1db93f0d14 QA: Add extension tags to tests
Certain tests only work when certain tests are installed. Tag them

Bug: T120715
Change-Id: I6b4333e5c45c41fc5699bf18f6b3a76556290df6
2015-12-07 20:27:25 +00:00
Baha 9932fee563 Add browser tests for ReadMore
Change-Id: Ia1f628b4f2e1af7d33dc6779a139c2800be82964
2015-12-04 15:43:45 +05:00