Commit graph

660 commits

Author SHA1 Message Date
Max Semenik bc24e8a71d Stop passing objects by reference
Bug: T193950
Change-Id: I36dc8a0f887bf11275f9cf3611651ca1091cd9f7
2019-11-14 22:17:56 -08:00
Umherirrender ae1862edba build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: Ic01a5c1b168daff1d778a4db11bf554f585336e5
2019-11-04 19:03:07 +01:00
Translation updater bot 3e330afcbc Localisation updates from https://translatewiki.net.
Change-Id: Ib8bd704a9b9ab0e08dbdb697bf7dd6fb67808c54
2019-10-25 09:19:22 +02:00
jdlrobson c9ec8dfadf Use mw.util.debounce
jquery.throttle-debounce is deprecated.

Bug: T213426
Change-Id: Ieffe20f44003e7dbb992e88c7927a14629da2db4
2019-10-24 18:49:38 +00:00
James D. Forrester 508223b06e build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: I44da6771b7642b73e0410882d6661463d04f831c
2019-10-11 11:26:08 -07:00
Translation updater bot edff37fc98 Localisation updates from https://translatewiki.net.
Change-Id: I9a09891fd8413afd248e9a3f96b74d5171427e61
2019-09-13 10:20:43 +02:00
Translation updater bot 96e3ebda01 Localisation updates from https://translatewiki.net.
Change-Id: If27301a76e8e730991f3151ea2e625ca82cdb61e
2019-09-04 10:15:03 +02:00
Translation updater bot 74f5630cfe Localisation updates from https://translatewiki.net.
Change-Id: I313dc9bcdeb7b21b931968ebc163bbc63c66af95
2019-08-30 10:04:55 +02:00
Translation updater bot 212035bde6 Localisation updates from https://translatewiki.net.
Change-Id: I32323367a2b006f2c6940d30cb19523a2204fd02
2019-08-28 10:53:44 +02:00
Jesús Martínez Novo be3385e6d5 Support other ways to get the description of the page
Currently, the extension queries the prop=description api to fetch the
description, but this api is only available if Wikibaseclient is installed.

Let's support other sources to fetch the page description from, too, or
disable it (by default) to sabe 85 bytes from each response by avoiding the
warning returned from the api when prop=description is not recognized.

A new configuration setting has been added: RelatedArticlesDescriptionSource.
It defaults to false (no description is fetched), but can be set to one of
those string values:

- wikidata: What's being used right now on WMF wikis
- textextracts: Extension:TextExtracts provides the prop=extracts api.
- pagedescription: Extension:Description2 provides a description page property, that can be queried by prop=pageprops&ppprop=description

Bug: T230947
Change-Id: I34410334ba9d6db1f686c7efb5722e2a51957145
2019-08-23 20:24:37 +02:00
libraryupgrader 95a2d7a7ba build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: Id48dd396a5b07efdd6486b4f69fe5f0fb9190885
2019-08-23 03:33:15 +00:00
jenkins-bot b8ded2df23 Merge "Fix background-size on thumbnails" 2019-08-07 19:05:43 +00:00
Saint Johann e0547ff7cc Fix background-size on thumbnails
Bug: T229664
Change-Id: I001e3aea67ca09bf657b3895c7e0bcb4c63412ea
2019-08-07 10:53:50 +00:00
libraryupgrader b7c1979278 build: Updating wdio-mediawiki to 0.4.0
Change-Id: I3eb03f459cc1fe36c120a0ae40240eaaa2b57752
2019-08-03 04:28:52 +00:00
Isarra b31970084f Use SkinAfterContent hook to place cards in the DOM
This allows skins to determine where the cards appear in a consistent
fashion with other extensions, and require minimal special handling from
the extension itself.

Also change default settings as to when RelatedArticle cards will appear
- keep the whitelist to allow projects to configure their usage such as
in the case of only wanting it on mobile, etc, but now that it should
just work in any given skin, default it to on for all so that it's easier
for the average third party to install for whatever use.

Note that this default setting change will not affect WMF wikis, as
wmgRelatedArticlesFooterWhitelistedSkins is explicitly set in the
wmf-config regardless.

Bug: T181242
Depends-On: I5b0ad889e633fde88c392577ce5373c81fc5486a
Change-Id: Iebd759c0d1a536768d18953f372664df762d9e04
2019-07-26 19:28:49 +00:00
libraryupgrader 4cdb540f75 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 24.0.0 → 26.0.0
* mediawiki/minus-x: 0.3.1 → 0.3.2

npm:
* lodash: 4.17.11 → 4.17.15
  * https://npmjs.com/advisories/1065
  * CVE-2019-10744
* set-value: 2.0.0 → 2.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* union-value: 1.0.0 → 1.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* mixin-deep: 1.3.1 → 1.3.2
  * https://npmjs.com/advisories/1013
  * CVE-2019-10746
* grunt-banana-checker: 0.7.0 → 0.7.1

Change-Id: I9728f2441f195fd1473f0eb8bc0cbaf28c505cfc
2019-07-19 11:57:33 -07:00
James D. Forrester e1490b3f38 build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Change-Id: I091a1caec5ccf141b04abb210e87987e17d78e58
2019-07-09 14:15:54 -07:00
Translation updater bot 14bb214ecb Localisation updates from https://translatewiki.net.
Change-Id: If11d1d3f65a869a7212a47f372a742bdd20d6bdd
2019-07-03 22:45:56 +02:00
Translation updater bot 81359d080b Localisation updates from https://translatewiki.net.
Change-Id: I8fb3364643b9384c3af0da6638f5b8f44c6b4d0d
2019-06-30 22:39:22 +02:00
libraryupgrader 72d37219e6 build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: I636ad49a31be0433519d3e8338b772742b8e3ea6
2019-06-10 10:33:19 +00:00
libraryupgrader b42020a033 build: Updating npm dependencies for security issues
* Updated grunt to 1.0.4, addressing:
  * https://npmjs.com/advisories/788
  * https://npmjs.com/advisories/813
* Updated stylelint-config-wikimedia to 0.6.0, addressing:
  * https://npmjs.com/advisories/786

Committed package-lock.json (T179229) too.

Change-Id: I6a32ed8cb552826053f9439b7a62a9e74f17b881
2019-06-08 19:32:41 +00:00
Volker E 2d7c4e979e Update 'noimage' to unified 'article' icon
Equivalent to latest 'article' icon in Design Style Guide and OOUI.
Also updating `.list-thumb-none` class to align icon and simplify
maintenance.

Bug: T222717
Change-Id: I49a89afa3d370abc4cf282a0bf8d44ee2751aa78
2019-06-05 17:05:31 -07:00
James D. Forrester 431e218ac8 build: Upgrade wdio-mocha-framework to be node10 compatible
Change-Id: Ie0176c0bd97488ea6c23e666035787cf7dfe7bb1
2019-06-03 14:54:40 -07:00
David Causse 51a19570eb Fix wgRelatedArticles*UseCirrusSearch var names in data.json
typo introduced in I5c6809392b0621bd0d58049597f6c0306e572607

Bug: T224879
Change-Id: I195cfd2a32b5a1737aed15d6c463a602ce54d6ad
2019-06-03 15:14:27 +02:00
Timo Tijhof 8becbc2b23 Omit 'wgRelatedArticles' from page view HTML when empty
* The extension already uses 'null' as placeholder in RelatedArticles
  instead of empty array. Update the doc comment in RelatedPagesGateway
  to reflect this (its code was already using the default operator
  to fallback to empty array, given empty arrays are not falsey in JS,
  but null is).

* Omit the key from the mw.config output in <head> on page views,
  when the value is null, given this is redundant information and consumes
  additional space.

Bug: T219342
Change-Id: I367f9d9423d66611d73d56f8a769d86d14d3de8b
2019-05-26 13:49:16 +01:00
Timo Tijhof 6a0d64d3f0 Remove 'wgRelatedArticles*CirrusSearch' from page view HTML
Bundle these with the module that needs it instead, this means
1. It is naturally only downloaded on pages where it is needed.
2. It doesn't block download/parse/render of the article HTML.
3. It doesn't delay time to mw.loader.load() for interactive
   functionality.

Bug: T219342
Change-Id: I5c6809392b0621bd0d58049597f6c0306e572607
2019-05-25 22:04:51 +00:00
Timo Tijhof a418550db3 ext.relatedArticles.readMore.bootstrap: Convert to 'packageFiles'
This enables use of module.exports and require() within the module,
and makes it easy to bundle additional data and scripts generated
by the server (without needing to subclass FileModule in PHP).

In particular, to bundle mw.config values with the module.
Currently the extension is adding these to the <head> of all
articles which delays rendering of the article content, and the
time to when JS can start to be fetched.

See <https://phabricator.wikimedia.org/T219342#5116773>.

Bug: T219342
Change-Id: I3f174418af8bfd83b0faabe484226e323714cb5b
2019-05-25 22:03:38 +00:00
James D. Forrester 1961f3ac94 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: I9f30135be10f0f4d6b085fa68cdde6b481edf268
2019-05-19 12:51:24 +00:00
Translation updater bot 9443ea4a42 Localisation updates from https://translatewiki.net.
Change-Id: I1abeae425585493dc9055d2f19062f3044cfe7d5
2019-05-15 09:14:15 +02:00
jenkins-bot c9d9528245 Merge "Add phan" 2019-05-09 08:55:11 +00:00
jenkins-bot 8c5073a0ff Merge "Remove unused ResourceLoaderMuHoganModule module" 2019-05-01 22:11:15 +00:00
jenkins-bot 3c5d8c701a Merge "Hygiene: Followup from 191fc2a" 2019-05-01 22:02:00 +00:00
Translation updater bot 57a9743cf9 Localisation updates from https://translatewiki.net.
Change-Id: Iacac4a11dfb133db802333c8511986361294830f
2019-05-01 22:30:20 +02:00
Jan Drewniak fcd4d1a272 Hygiene: Followup from 191fc2a
pass a collection of jQuery objects to `.append` instead of
and array.

Use `.css` instead of `.attr` to set thumbnail background image.

Change a unit to reflect the escaping pattern of the `.css` method

Bug: T219846
Change-Id: I6359be2db6c7c7a8e4b52296e0801d4ded921b46
2019-05-01 22:28:47 +02:00
jdlrobson fcfa09184d Remove unused ResourceLoaderMuHoganModule module
Followup from 191fc2a

Bug: T219846
Change-Id: Id5abee14f897204f072420cec2d6fdcf40cd37ff
2019-05-01 11:00:12 -07:00
Umherirrender 495c8db323 Add phan
Change-Id: I94227b61dd788ffaaf05da5c1725f1b9708575a3
2019-04-25 20:49:07 +02:00
Volker E a7e6c196f7 Remove -o-linear-gradient for Opera 11.5, Opera Mobile 12
Removing obsolete vendor property specifically for old subversion
of Opera < 12.1, desktop and mobile.

Change-Id: Id9a8a9fffb594f3973486f7be243329abdc9a5fa
2019-04-17 12:54:23 -07:00
Jan Drewniak 191fc2af9d Remove muhogan templates and module
Removes the muhogan module along with the templates and replacing
them with jQuery DOM construction.

Bug: T219846
Change-Id: I246f9c46ea2cc5721ddd57efcf58fae9fd947c58
2019-04-10 17:14:28 +02:00
Translation updater bot d9de09ca3f Localisation updates from https://translatewiki.net.
Change-Id: Ia7b91642a58798e6ce43bf7a207ab1e66be231ba
2019-04-05 22:27:39 +02:00
James D. Forrester 2066d438ae build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0
Change-Id: Ie1f3e5f9ead8f69da554fb9a3260fa44b1c91f4e
2019-04-03 16:21:00 -07:00
Volker E 1fc22a3892 Remove .background-size() mixin usage
Removing deprecated LESS `.background-size()` mixin calls.

Bug: T219956
Change-Id: I2602fb46b3ae757ad2f1653ff3862fbc59adfc9c
2019-04-02 19:58:07 -07:00
Kunal Mehta 3b7728f7cf Avoid use of func_get_args()
Change-Id: I7e0fb290be734dcbec39be9bcb9f17551e785de6
2019-03-09 18:36:30 -08:00
Ed Sanders 26b15d19b9 build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I01388bfdda108e9e80b32d68983e1d826d0db784
2019-02-10 16:46:48 +00:00
libraryupgrader 9918d2f696 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I8020f5480dcc5f5a731ba629a878b0c853d60465
2019-02-07 03:31:29 +00:00
Translation updater bot 6b4cda1417 Localisation updates from https://translatewiki.net.
Change-Id: Ia644a4d32a319fad81ead06ce52258b86d371484
2019-02-04 22:15:44 +01:00
Translation updater bot 940f171ef4 Localisation updates from https://translatewiki.net.
Change-Id: Ie294d8395b97e9c7dc686e4a97f5be8dbc13deca
2019-01-25 22:29:21 +01:00
Volker E 9a5d59caee build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Also enabling 'no-descending-specificity' rule and the same time
simplify VE hidden rule.

Change-Id: Idad811e7fca681883fccbc961c70f49e2b356c02
2019-01-16 19:26:36 -08:00
Translation updater bot c32365b81f Localisation updates from https://translatewiki.net.
Change-Id: If3cee2ecee3cecab465522aff0bff2c5b2c36ca0
2019-01-13 22:13:40 +01:00
Translation updater bot 00e76f2228 Localisation updates from https://translatewiki.net.
Change-Id: Ida69961b37ffcb596f3512df2f6c3712ec3246b9
2018-12-01 22:17:39 +01:00
libraryupgrader b203a142f7 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I3e5dc39c5edf917bfb586b47a430b669a4660fa8
2018-11-16 08:26:25 +00:00