Commit graph

639 commits

Author SHA1 Message Date
Volker E 2d7c4e979e Update 'noimage' to unified 'article' icon
Equivalent to latest 'article' icon in Design Style Guide and OOUI.
Also updating `.list-thumb-none` class to align icon and simplify
maintenance.

Bug: T222717
Change-Id: I49a89afa3d370abc4cf282a0bf8d44ee2751aa78
2019-06-05 17:05:31 -07:00
James D. Forrester 431e218ac8 build: Upgrade wdio-mocha-framework to be node10 compatible
Change-Id: Ie0176c0bd97488ea6c23e666035787cf7dfe7bb1
2019-06-03 14:54:40 -07:00
David Causse 51a19570eb Fix wgRelatedArticles*UseCirrusSearch var names in data.json
typo introduced in I5c6809392b0621bd0d58049597f6c0306e572607

Bug: T224879
Change-Id: I195cfd2a32b5a1737aed15d6c463a602ce54d6ad
2019-06-03 15:14:27 +02:00
Timo Tijhof 8becbc2b23 Omit 'wgRelatedArticles' from page view HTML when empty
* The extension already uses 'null' as placeholder in RelatedArticles
  instead of empty array. Update the doc comment in RelatedPagesGateway
  to reflect this (its code was already using the default operator
  to fallback to empty array, given empty arrays are not falsey in JS,
  but null is).

* Omit the key from the mw.config output in <head> on page views,
  when the value is null, given this is redundant information and consumes
  additional space.

Bug: T219342
Change-Id: I367f9d9423d66611d73d56f8a769d86d14d3de8b
2019-05-26 13:49:16 +01:00
Timo Tijhof 6a0d64d3f0 Remove 'wgRelatedArticles*CirrusSearch' from page view HTML
Bundle these with the module that needs it instead, this means
1. It is naturally only downloaded on pages where it is needed.
2. It doesn't block download/parse/render of the article HTML.
3. It doesn't delay time to mw.loader.load() for interactive
   functionality.

Bug: T219342
Change-Id: I5c6809392b0621bd0d58049597f6c0306e572607
2019-05-25 22:04:51 +00:00
Timo Tijhof a418550db3 ext.relatedArticles.readMore.bootstrap: Convert to 'packageFiles'
This enables use of module.exports and require() within the module,
and makes it easy to bundle additional data and scripts generated
by the server (without needing to subclass FileModule in PHP).

In particular, to bundle mw.config values with the module.
Currently the extension is adding these to the <head> of all
articles which delays rendering of the article content, and the
time to when JS can start to be fetched.

See <https://phabricator.wikimedia.org/T219342#5116773>.

Bug: T219342
Change-Id: I3f174418af8bfd83b0faabe484226e323714cb5b
2019-05-25 22:03:38 +00:00
James D. Forrester 1961f3ac94 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: I9f30135be10f0f4d6b085fa68cdde6b481edf268
2019-05-19 12:51:24 +00:00
Translation updater bot 9443ea4a42 Localisation updates from https://translatewiki.net.
Change-Id: I1abeae425585493dc9055d2f19062f3044cfe7d5
2019-05-15 09:14:15 +02:00
jenkins-bot c9d9528245 Merge "Add phan" 2019-05-09 08:55:11 +00:00
jenkins-bot 8c5073a0ff Merge "Remove unused ResourceLoaderMuHoganModule module" 2019-05-01 22:11:15 +00:00
jenkins-bot 3c5d8c701a Merge "Hygiene: Followup from 191fc2a" 2019-05-01 22:02:00 +00:00
Translation updater bot 57a9743cf9 Localisation updates from https://translatewiki.net.
Change-Id: Iacac4a11dfb133db802333c8511986361294830f
2019-05-01 22:30:20 +02:00
Jan Drewniak fcd4d1a272 Hygiene: Followup from 191fc2a
pass a collection of jQuery objects to `.append` instead of
and array.

Use `.css` instead of `.attr` to set thumbnail background image.

Change a unit to reflect the escaping pattern of the `.css` method

Bug: T219846
Change-Id: I6359be2db6c7c7a8e4b52296e0801d4ded921b46
2019-05-01 22:28:47 +02:00
jdlrobson fcfa09184d Remove unused ResourceLoaderMuHoganModule module
Followup from 191fc2a

Bug: T219846
Change-Id: Id5abee14f897204f072420cec2d6fdcf40cd37ff
2019-05-01 11:00:12 -07:00
Umherirrender 495c8db323 Add phan
Change-Id: I94227b61dd788ffaaf05da5c1725f1b9708575a3
2019-04-25 20:49:07 +02:00
Volker E a7e6c196f7 Remove -o-linear-gradient for Opera 11.5, Opera Mobile 12
Removing obsolete vendor property specifically for old subversion
of Opera < 12.1, desktop and mobile.

Change-Id: Id9a8a9fffb594f3973486f7be243329abdc9a5fa
2019-04-17 12:54:23 -07:00
Jan Drewniak 191fc2af9d Remove muhogan templates and module
Removes the muhogan module along with the templates and replacing
them with jQuery DOM construction.

Bug: T219846
Change-Id: I246f9c46ea2cc5721ddd57efcf58fae9fd947c58
2019-04-10 17:14:28 +02:00
Translation updater bot d9de09ca3f Localisation updates from https://translatewiki.net.
Change-Id: Ia7b91642a58798e6ce43bf7a207ab1e66be231ba
2019-04-05 22:27:39 +02:00
James D. Forrester 2066d438ae build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0
Change-Id: Ie1f3e5f9ead8f69da554fb9a3260fa44b1c91f4e
2019-04-03 16:21:00 -07:00
Volker E 1fc22a3892 Remove .background-size() mixin usage
Removing deprecated LESS `.background-size()` mixin calls.

Bug: T219956
Change-Id: I2602fb46b3ae757ad2f1653ff3862fbc59adfc9c
2019-04-02 19:58:07 -07:00
Kunal Mehta 3b7728f7cf Avoid use of func_get_args()
Change-Id: I7e0fb290be734dcbec39be9bcb9f17551e785de6
2019-03-09 18:36:30 -08:00
Ed Sanders 26b15d19b9 build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I01388bfdda108e9e80b32d68983e1d826d0db784
2019-02-10 16:46:48 +00:00
libraryupgrader 9918d2f696 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I8020f5480dcc5f5a731ba629a878b0c853d60465
2019-02-07 03:31:29 +00:00
Translation updater bot 6b4cda1417 Localisation updates from https://translatewiki.net.
Change-Id: Ia644a4d32a319fad81ead06ce52258b86d371484
2019-02-04 22:15:44 +01:00
Translation updater bot 940f171ef4 Localisation updates from https://translatewiki.net.
Change-Id: Ie294d8395b97e9c7dc686e4a97f5be8dbc13deca
2019-01-25 22:29:21 +01:00
Volker E 9a5d59caee build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Also enabling 'no-descending-specificity' rule and the same time
simplify VE hidden rule.

Change-Id: Idad811e7fca681883fccbc961c70f49e2b356c02
2019-01-16 19:26:36 -08:00
Translation updater bot c32365b81f Localisation updates from https://translatewiki.net.
Change-Id: If3cee2ecee3cecab465522aff0bff2c5b2c36ca0
2019-01-13 22:13:40 +01:00
Translation updater bot 00e76f2228 Localisation updates from https://translatewiki.net.
Change-Id: Ida69961b37ffcb596f3512df2f6c3712ec3246b9
2018-12-01 22:17:39 +01:00
libraryupgrader b203a142f7 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I3e5dc39c5edf917bfb586b47a430b669a4660fa8
2018-11-16 08:26:25 +00:00
Ed Sanders 7b0c26ba59 build: Update devDependencies
eslint-config-wikimedia      0.5.0  →   0.8.1
 grunt-eslint                20.1.0  →  21.0.0
 grunt-stylelint              0.9.0  →  0.10.1
 stylelint                    8.2.0  →   9.2.0
 stylelint-config-wikimedia   0.4.2  →   0.4.3

Add "eslint-plugin-qunit"

Change-Id: I4761b12a9c3d4cb35bb891a7f999a84be46f543e
2018-11-12 22:24:07 +00:00
Translation updater bot b9f89c7345 Localisation updates from https://translatewiki.net.
Change-Id: I0276c84fcae297895ab12ea9994a606fd8d2aeff
2018-11-05 22:24:42 +01:00
Translation updater bot beb4887a3d Localisation updates from https://translatewiki.net.
Change-Id: I766bdae86d6b6936321efd9679c93f54d0cd1bd1
2018-11-04 22:42:36 +01:00
Volker E 68e0e12794 Increase headline color contrast slightly to conform to AA ratio
Bug: T208343
Change-Id: I31d3c0a06de9597a8fc1367a7d3b906b8ffe9921
2018-10-30 12:33:45 -07:00
Translation updater bot ddf0654fa8 Localisation updates from https://translatewiki.net.
Change-Id: Ic5e9e93ca65fc32ba813b12045be964ed95fe191
2018-10-19 22:20:00 +02:00
libraryupgrader bb1c52f03e build: Updating npm dependencies for security issues
* Updated grunt to 1.0.3, addressing:
  * https://npmjs.com/advisories/577
  * CVE-2018-3721

Change-Id: Ie9eab8555af9470b46fcca24260bbae9d5ab570e
2018-10-11 10:37:05 +00:00
Translation updater bot 150edb6da9 Localisation updates from https://translatewiki.net.
Change-Id: Iebd63b7696e24dead2e28176e22898bf1411cea8
2018-09-26 13:46:15 +02:00
jdlrobson 6b49ddff1b Remove EventLogging/A-B test code from RelatedArticles
With RelatedArticlesEnabledBucketSize now removed, installation of this
extension will turn it on for 100% users without any mechanism to turn
it off.

Additional changes:
* Bump version
* Add Readers team to contributors

Bug: T202306
Change-Id: I7dc270a06dd3afd4e894c8298165d6d6d4fda8d6
2018-09-20 11:13:13 -07:00
Jan Drewniak 6856ef8b5e Renaming QUnit test files from "test_" to "test.js"
Updates QUnit test files from starting with "test_" to ending with
"test.js" in accordance with the Readers Wed coding conventions.

https://www.mediawiki.org/wiki/Reading/Web/Coding_conventions

Bug: T197884
Change-Id: I3c15385d22d308b8b465985ca55e8b802d72dae4
2018-09-19 14:54:48 +02:00
Fomafix 00405b0309 Remove mediaWiki and jQuery from eslint globals
Remove all mappings in the closures like in
I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b in core.

Change-Id: Ie9a2fadb8e276774784a4937bb5c3ec11f213352
2018-09-15 17:54:03 +00:00
jenkins-bot 609b2811ac Merge "Selenium: Simplify selenium-daily NPM script" 2018-09-11 10:00:04 +00:00
libraryupgrader 37beb7dfae build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I327f22412a6ad54eae8d5c70e0a4e751c5022a3c
2018-09-08 05:21:57 +00:00
Translation updater bot 3207196964 Localisation updates from https://translatewiki.net.
Change-Id: I9fc6e430c445053f1325504e6ec59f9efb1ff931
2018-09-03 22:15:32 +02:00
Željko Filipin 937980a9b0 Selenium: Simplify selenium-daily NPM script
selenium-daily now just calls selenium-test. Environment variables are set up in
the Jenkins job, so they are removed.
selenium-daily might seem redundant, but it provides flexibility. In case a
repository does not want to run all tests daily, that's easily fixed by updating the
selenium-daily script.

Bug: T188742
Change-Id: If0d3b508fb9a711afdfd1d18086071ed4c9cb0ed
2018-09-03 17:29:37 +02:00
libraryupgrader c199126902 build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: Iecc747be0ae2f2c4c3c6b4cf481d5bd5fc4a0bc1
2018-09-03 14:19:23 +00:00
libraryupgrader c46c56ae65 build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I803ea3fb34cc09e35f584512aef887fbb9d42dd8
2018-09-01 13:45:56 +00:00
jenkins-bot 90681f1a79 Merge "Remove unused jshint comment" 2018-08-21 07:39:27 +00:00
libraryupgrader fbe7003f21 build: Updating mediawiki/phan-taint-check-plugin to 1.3.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: I7fd1fec50544b0b29aa2b9fa03bdbe1b33cf761b
2018-08-19 15:55:19 +00:00
Fomafix 969ae7c05f Remove unused jshint comment
Change-Id: If1db410a48a754a4f892b6164f6a4997bed3bec4
2018-08-17 14:06:24 +02:00
Fomafix 0464e7a7c0 Remove eslint rule "no-use-before-define": 1
Add no-use-before-define to the line where the rules is violated.

Change-Id: Ieb50b11292cff6b40fdd5f06c76d61bb01e86e4c
2018-08-17 13:29:08 +02:00
Fomafix 0fa064728f Use native JavaScript instead of jQuery
Replace
* $.each( array, function ( index, value ) { ... } ) by
  array.forEach( function ( value ) { ... } )

* $.map( array, function ( value ) { ... } ) by
  array.map( function ( value ) { ... } )

* $.isArray( var ) by
  Array.isArray( var )

* $.isFunction( var ) by
  typeof var === 'function'

Change-Id: I450f5a75eb9c3fe20517da02986b0a491ebca67a
2018-08-17 12:45:12 +02:00