wikimedia/mediawiki-extensions-RelatedArticles
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RelatedArticles synced 2024-11-24 00:05:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace empty() with falsy check

Browse source 
empty() should only be used to suppress errors
When the type of the variable is array,
a falsy check is the same (checks for null, false and empty array)
Found by a new phan plugin (T234237)

Change-Id: Iafd6d3bae30038bac2fad967924a9461aa57761b
This commit is contained in:
Umherirrender 2023-10-21 21:58:11 +02:00
parent fa502f63e8
commit 91915dd6ff
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Hooks.php
View file

@ -88,7 +88,7 @@ class Hooks implements
->makeConfig( 'RelatedArticles' );
$skins = $config->get( 'RelatedArticlesFooterAllowedSkins' );
$skinName = $skin->getSkinName();
return empty( $skins ) || in_array( $skinName, $skins );
return !$skins || in_array( $skinName, $skins );
}
/**