From 627c2541575423cf3b1b7ac6d7abbeba766476b1 Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Tue, 18 Apr 2017 16:25:19 +0200 Subject: [PATCH] Add stylelint for less files Fixed the following rules: string-quotes declaration-property-value-blacklist number-leading-zero Change-Id: I7c8021070b69cd60ac010e90b3bc13a033d695e2 --- .stylelintrc | 6 ++++++ Gruntfile.js | 10 +++++++++- package.json | 4 +++- resources/ext.relatedArticles.readMore/readMore.less | 6 +++--- 4 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 .stylelintrc diff --git a/.stylelintrc b/.stylelintrc new file mode 100644 index 00000000..cae35a02 --- /dev/null +++ b/.stylelintrc @@ -0,0 +1,6 @@ +{ + "extends": "stylelint-config-wikimedia", + "rules": { + "no-descending-specificity": null + } +} diff --git a/Gruntfile.js b/Gruntfile.js index 1344eb15..026ead34 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -5,6 +5,7 @@ module.exports = function ( grunt ) { grunt.loadNpmTasks( 'grunt-eslint' ); grunt.loadNpmTasks( 'grunt-jsonlint' ); grunt.loadNpmTasks( 'grunt-banana-checker' ); + grunt.loadNpmTasks( 'grunt-stylelint' ); grunt.initConfig( { eslint: { @@ -17,11 +18,18 @@ module.exports = function ( grunt ) { jsonlint: { all: [ '**/*.json', + '.stylelintrc', + '!node_modules/**' + ] + }, + stylelint: { + all: [ + '**/*.less', '!node_modules/**' ] } } ); - grunt.registerTask( 'test', [ 'eslint', 'jsonlint', 'banana' ] ); + grunt.registerTask( 'test', [ 'eslint', 'jsonlint', 'banana', 'stylelint' ] ); grunt.registerTask( 'default', 'test' ); }; diff --git a/package.json b/package.json index 7a68d8ab..e213bdf7 100644 --- a/package.json +++ b/package.json @@ -9,6 +9,8 @@ "grunt-banana-checker": "0.4.0", "grunt-cli": "0.1.13", "grunt-eslint": "^19.0.0", - "grunt-jsonlint": "1.0.7" + "grunt-jsonlint": "1.0.7", + "grunt-stylelint": "0.6.0", + "stylelint-config-wikimedia": "0.4.1" } } diff --git a/resources/ext.relatedArticles.readMore/readMore.less b/resources/ext.relatedArticles.readMore/readMore.less index 7f613eb6..18057a27 100644 --- a/resources/ext.relatedArticles.readMore/readMore.less +++ b/resources/ext.relatedArticles.readMore/readMore.less @@ -1,9 +1,9 @@ -@import "mediawiki.ui/variables"; +@import 'mediawiki.ui/variables'; .ra-read-more { h2 { - border-bottom: none; - font-size: .8em; + border-bottom: 0; + font-size: 0.8em; font-weight: normal; color: @colorGray9; padding-bottom: 0.5em;