wikimedia/mediawiki-extensions-RelatedArticles
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/RelatedArticles synced 2024-09-24 19:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove CustomData extension dependency

Browse source 
The related pages stored via CustomData  will have been migrated to the
cached ParserOutput class over the last 30 days, per I30bd17f, so all
interactions with/references to CustomData can be removed.

Bug: T115019
Change-Id: I36919d2443f0ee02ac6baf9a4d2228b028b2e6ed
This commit is contained in:
Sam Smith 2015-11-10 17:03:06 +00:00
parent 35193ffc66
commit 239705928d
1 changed files with 1 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
includes/Hooks.php
View file

@ -3,8 +3,6 @@
namespace RelatedArticles;
use Parser;
// FIXME: Remove in 30 days (T114915)
use CustomData;
use Exception;
use Title;
use SkinTemplate;
@ -84,36 +82,12 @@ class Hooks {
return true;
}
/**
* Gets the global instance of the {@see CustomData} class for backwards compatibility.
*
* FIXME: This can be removed when cache clears. (T114915)
* If the instance isn't available, then an exception is thrown.
*
* @throws Exception When the CustomData extension isn't properly installed
* @deprecated
* @return CustomData
*/
public static function getCustomData() {
global $wgCustomData;
if ( !$wgCustomData instanceof CustomData ) {
throw new Exception(
'CustomData extension isn\'t properly installed and is needed to view pages in cache.'
);
}
return $wgCustomData;
}
/**
* Passes the related articles list from the cached parser output
* object to the output page for rendering.
*
* The list of related articles will be retrieved using
* <code>ParserOutput#getExtensionData</code> and, if that fails,
* <code>CustomData#getParserData</code>.
* <code>ParserOutput#getExtensionData</code>.
*
* @param OutputPage $out
* @param ParserOutput $parserOutput
@ -121,12 +95,6 @@ class Hooks {
*/
public static function onOutputPageParserOutput( OutputPage &$out, ParserOutput $parserOutput ) {
$related = $parserOutput->getExtensionData( 'RelatedArticles' );
// Backwards compatability with old cached pages. In cached pages, related articles will not be in
// ParserOutput but will still be in custom data so let's retrieve them from there.
// FIXME: Remove in 30 days (T114915)
if ( !$related ) {
$related = self::getCustomData()->getParserData( $out, 'RelatedArticles' );
}
if ( $related ) {
$out->setProperty( 'RelatedArticles', $related );