Commit graph

9 commits

Author SHA1 Message Date
Mark A. Hershberger 6003693caf followup r76848 by using wfEscapeWikiText() on all bits except links. Escape links using wfEscapeWikiText() that, after we've parsed them with parse_url(), don't have a scheme in our list of validSchemes. 2010-11-19 21:02:01 +00:00
Mark A. Hershberger b6befdf40b followup r76848 Make sure to use wfEscapeWikiText 2010-11-19 19:01:09 +00:00
Mark A. Hershberger d997781fb4 * Remove references to unused charset handling.
* Remove references to unused config variables.
* Consolidate renderItem() to a single loop instead of a separate one for highlighting displayFields.
* Make sure everything gets htmlspecialchars() treatment.
o
2010-11-16 23:21:36 +00:00
Mark A. Hershberger a5321b114b * Remove the call to disableCache(), that, upon double-checking, does undermine the caching that updateCacheExpiry() is trying to set up in the very next line.
* Fix renderItem so that it isn't overly complex and just subsitutes the parsed contents of RSS elements (e.g. {{{description}}} is substituted with the contents of the <description> tag).
2010-11-16 22:06:59 +00:00
Roan Kattouw 61f5f7caba RSS extension:
* Prefix memcached keys with 'rss'
* Check is_array() rather than != null before using list() on the cache entry
* Fix language in comment
2010-11-13 19:16:39 +00:00
Roan Kattouw ff4e370bed RSS: instanceOf -> instanceof, $ERROR -> $error 2010-11-13 19:11:28 +00:00
Jack Phoenix 4e23b840bc RSS: coding style and documentation tweaks 2010-11-05 00:59:28 +00:00
Mark A. Hershberger 4a06accf23 don't fail where itemTemplate is filled with 0s 2010-11-04 23:47:06 +00:00
Mark A. Hershberger 3aa74a03f8 Re Roan's new review on IRC yesterday:
* Add function documentation that I should have written before.
* Create separate RSSParser class to clean up RSS.php
* Create separate RSSHooks class to handle parser initialization and
  public interface for parser to use.
* Move User Agent definition to $wgRSSUserAgent from a define.
* Eliminate references to $wgRSSUseGzip (since were using MW's
  internal HTTP client, it didn't do anything anyway, ATM).

Re Tim's emailed review (discovered yesterday):
* Switch to DOMXPath::query() from DOMXPath::evaluate() at Tim's
  suggestion.
* Move highlighting callback to its own class, RSSHighlighter, so that
  it works as a callback without create_function() and other mess.
2010-11-04 23:19:00 +00:00