Commit graph

9 commits

Author SHA1 Message Date
Mark A. Hershberger e03eee9134 Update per Reedy's mini-review on IRC:
* Make parens more spacey
* Use empty array instead of null for default.
2011-05-06 16:40:14 +00:00
Mark A. Hershberger 518d4b7a17 Update RSS to add the ability to restrict per-namespace. 2011-05-06 16:21:43 +00:00
Sam Reed 334d5e60b0 Fixup a few bits of documentation 2011-01-08 01:33:42 +00:00
Mark A. Hershberger a5321b114b * Remove the call to disableCache(), that, upon double-checking, does undermine the caching that updateCacheExpiry() is trying to set up in the very next line.
* Fix renderItem so that it isn't overly complex and just subsitutes the parsed contents of RSS elements (e.g. {{{description}}} is substituted with the contents of the <description> tag).
2010-11-16 22:06:59 +00:00
Mark A. Hershberger c06345b95e Add back cache setting that was accidently removed 2010-11-15 23:47:12 +00:00
Roan Kattouw ff4e370bed RSS: instanceOf -> instanceof, $ERROR -> $error 2010-11-13 19:11:28 +00:00
Jack Phoenix 4e23b840bc RSS: coding style and documentation tweaks 2010-11-05 00:59:28 +00:00
Mark A. Hershberger 81d995c0aa Remove bogus check for !isGood() status. 2010-11-04 23:38:47 +00:00
Mark A. Hershberger 3aa74a03f8 Re Roan's new review on IRC yesterday:
* Add function documentation that I should have written before.
* Create separate RSSParser class to clean up RSS.php
* Create separate RSSHooks class to handle parser initialization and
  public interface for parser to use.
* Move User Agent definition to $wgRSSUserAgent from a define.
* Eliminate references to $wgRSSUseGzip (since were using MW's
  internal HTTP client, it didn't do anything anyway, ATM).

Re Tim's emailed review (discovered yesterday):
* Switch to DOMXPath::query() from DOMXPath::evaluate() at Tim's
  suggestion.
* Move highlighting callback to its own class, RSSHighlighter, so that
  it works as a callback without create_function() and other mess.
2010-11-04 23:19:00 +00:00