Commit graph

23 commits

Author SHA1 Message Date
Jack Phoenix 4e23b840bc RSS: coding style and documentation tweaks 2010-11-05 00:59:28 +00:00
Mark A. Hershberger 3aa74a03f8 Re Roan's new review on IRC yesterday:
* Add function documentation that I should have written before.
* Create separate RSSParser class to clean up RSS.php
* Create separate RSSHooks class to handle parser initialization and
  public interface for parser to use.
* Move User Agent definition to $wgRSSUserAgent from a define.
* Eliminate references to $wgRSSUseGzip (since were using MW's
  internal HTTP client, it didn't do anything anyway, ATM).

Re Tim's emailed review (discovered yesterday):
* Switch to DOMXPath::query() from DOMXPath::evaluate() at Tim's
  suggestion.
* Move highlighting callback to its own class, RSSHighlighter, so that
  it works as a callback without create_function() and other mess.
2010-11-04 23:19:00 +00:00
Mark A. Hershberger 70cd9b0503 re r75046 - implement highlighting in a (hopefully) less ugly way 2010-11-02 17:56:35 +00:00
Mark A. Hershberger b327d5d893 follow up r75046: Quote regex chars in variable strings used in preg_* 2010-11-02 15:26:19 +00:00
Mark A. Hershberger d5afc1af52 * Add note about security measures we're taking.
* Protect against possibility where rss member in renderRss is not an
  object.
* Move user-agent string up to a define().
* Remove use of $rssTemp var in renderItem() by inlining code.
2010-11-01 23:08:06 +00:00
Mark A. Hershberger 19fa56a6e9 * Add member $displayFields so that we don't highlight and/or filter
on stuff the user will never see.
* Clean up and fix canDisplay() and filter() methods so they actually
  works.
2010-11-01 21:14:26 +00:00
Mark A. Hershberger fd95eaf9cf minor stylize 2010-11-01 21:03:22 +00:00
Mark A. Hershberger 153cd40ef1 * Switch to $wgMemc from $parserMemc re 75799
* Change last_modified member var to lastModified re Pre-commit Checklist
2010-11-01 18:48:34 +00:00
Mark A. Hershberger 537efdd554 stylize, remove error_log 2010-11-01 18:29:09 +00:00
Mark A. Hershberger 76910c268b * Remove RSSCache.php and use $parserMemc to store parsed RSS feeds.
* Remove RSSFetch.php and move functionality to main RSS class
* Simplify how RSSData is constructed so we can pass it a DOMDocument
  object instead of an HTTPResponse.
* Move wf functions into RSS class since they shouldn't really be
  globally available.
2010-11-01 16:25:04 +00:00
Roan Kattouw 63eb8cf7d4 Stylize RSS extension 2010-10-20 18:28:47 +00:00
Jack Phoenix a4b3195671 RSS: follow-up to r75046: coding style tweaks 2010-10-20 11:25:10 +00:00
Mark A. Hershberger 4f78c58549 version bump 2010-10-19 22:28:12 +00:00
Mark A. Hershberger e14f1ce5f2 * Use [[Template:RSSPost]] (and [[Mediawiki:Rss-item]]) (or another
specified template) to display the feeds and remove hard-coded HTML.
* Add check to make sure the cache dir is writable and put an error in
  the debug log if not.
* Remove Snoopy.class.php — replace with use of the Http class.
* Remove RSSParse.php — which was a copy of MagpieRSS and use plain
  XML parsing.  MagpieRSS looks unmaintained and has security
  problems.  http://www.madirish.net/?article=253 
* Remove references to Magpie RSS
* Remove (over?) use of wf{Supress,Restore}Warnings
* Construct simple RSSData class for normalizing (some of) the feed
  data.
2010-10-19 21:54:53 +00:00
Matěj Grabovský 8f4a8c9bb6 Removed description in $wgExtensionCredits where descriptionmsg was used 2010-08-10 15:27:44 +00:00
Jack Phoenix 76e8fc3151 RSS: wfLoadExtensionMessages() is not needed for 1.16/trunk 2010-07-23 15:28:57 +00:00
Jack Phoenix ffdd42f217 committing my work on RSS extension. Now this extension should be totally self-contained. RSSCache.php, RSSFetch.php and RSSParse.php are MagpieRSS extension files by Kellan Elliott-McCrea, with some MediaWikification by me. Snoopy.class.php is Snoopy, with some coding style changes and whatnot by me.
to-do: use memcached for caching instead of RSSCache.php
2010-07-23 15:26:27 +00:00
Jeroen De Dauw 9fc917aca8 1.7 release 2010-07-23 14:17:46 +00:00
Jeroen De Dauw b94a7002b7 Stylized 2010-07-23 14:14:05 +00:00
Jeroen De Dauw da5d738c82 * Cleaned up extension somewhat
* Included MagpieRSS library
2010-07-23 14:01:46 +00:00
Raimond Spekking 0c0ca6c699 Follow-up r69759: Add i18n file and add extension to Translatewiki 2010-07-23 08:02:27 +00:00
Jeroen De Dauw ab9b4503b6 oops, double <?php 2010-07-22 23:08:50 +00:00
Jeroen De Dauw 7938dd2b19 Adding RSS extension to the repo, instead of just having the code on mediawiki.org. Hope I got the svn import command right... 2010-07-22 22:07:15 +00:00