Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation and to remove the exclusion of the
sniff.
The activated sniff avoids that new code is missing doc-typehints or
real-typehints.
Adding a @var type to RSSData->items triggers a SecurityCheck-XSS issue by phan, but all is dealing with wikitext when building the items, so that looks like a false positive
Change-Id: I4f1d17372d62f02fe7447f5bf5e75b9471d7a338
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic
Additional changes:
* Dropped .inc files from .phpcs.xml (T200956).
* Added the `wikimedia/mediawiki` profile in .eslintrc.json (T262222).
* Removed globals `mw`, `OO`, included via `wikimedia/mediawiki` profile (T262222).
* Dropped the emtpy global definition in .eslintrc.json.
Change-Id: I99fb7d7a3a1f26c4d3a6db9270b73469f9cb1e96
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.
Change-Id: I8512d1e1f1cf8c6b35800639f543b8e576502c7b
Remove the two PHP Code Sniffer exclusions and fix the code to
pass (including clarifying code docs). Also update two dev
dependencies (which require no changes).
Change-Id: I953489b6b210dbc0bcbcbe57c574039a4ce0255c
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
Change-Id: I4784b14fb5a1558227c66217db0c25a709c73927
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
Change-Id: Ic4069c1d358456f646eb4cf1933d424328aaafa5
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing
The following sniffs now pass and were enabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
Change-Id: I5ed0dc8974bd4e2c0202d7bdcfdb42242bd25ae9
