Commit graph

9 commits

Author SHA1 Message Date
Jack Phoenix 4e23b840bc RSS: coding style and documentation tweaks 2010-11-05 00:59:28 +00:00
Mark A. Hershberger 3aa74a03f8 Re Roan's new review on IRC yesterday:
* Add function documentation that I should have written before.
* Create separate RSSParser class to clean up RSS.php
* Create separate RSSHooks class to handle parser initialization and
  public interface for parser to use.
* Move User Agent definition to $wgRSSUserAgent from a define.
* Eliminate references to $wgRSSUseGzip (since were using MW's
  internal HTTP client, it didn't do anything anyway, ATM).

Re Tim's emailed review (discovered yesterday):
* Switch to DOMXPath::query() from DOMXPath::evaluate() at Tim's
  suggestion.
* Move highlighting callback to its own class, RSSHighlighter, so that
  it works as a callback without create_function() and other mess.
2010-11-04 23:19:00 +00:00
Mark A. Hershberger 8bded939e4 Add missing note about security re r75841 2010-11-01 23:09:51 +00:00
Mark A. Hershberger 537efdd554 stylize, remove error_log 2010-11-01 18:29:09 +00:00
Mark A. Hershberger 76910c268b * Remove RSSCache.php and use $parserMemc to store parsed RSS feeds.
* Remove RSSFetch.php and move functionality to main RSS class
* Simplify how RSSData is constructed so we can pass it a DOMDocument
  object instead of an HTTPResponse.
* Move wf functions into RSS class since they shouldn't really be
  globally available.
2010-11-01 16:25:04 +00:00
Roan Kattouw 63eb8cf7d4 Stylize RSS extension 2010-10-20 18:28:47 +00:00
Jack Phoenix a4b3195671 RSS: follow-up to r75046: coding style tweaks 2010-10-20 11:25:10 +00:00
Mark A. Hershberger 13bc857751 Remove Extraneous var_dump from r75046 2010-10-19 23:33:41 +00:00
Mark A. Hershberger e14f1ce5f2 * Use [[Template:RSSPost]] (and [[Mediawiki:Rss-item]]) (or another
specified template) to display the feeds and remove hard-coded HTML.
* Add check to make sure the cache dir is writable and put an error in
  the debug log if not.
* Remove Snoopy.class.php — replace with use of the Http class.
* Remove RSSParse.php — which was a copy of MagpieRSS and use plain
  XML parsing.  MagpieRSS looks unmaintained and has security
  problems.  http://www.madirish.net/?article=253 
* Remove references to Magpie RSS
* Remove (over?) use of wf{Supress,Restore}Warnings
* Construct simple RSSData class for normalizing (some of) the feed
  data.
2010-10-19 21:54:53 +00:00