Commit graph

39 commits

Author SHA1 Message Date
Wikinaut b1f1e0b517 Bug 55763
Change-Id: I4329c4e652f3025ddcca4bcd38dedc33b1a378a6
2013-10-17 23:40:17 +02:00
Kevin Israel 8e0763a2cb Fix parsing from CLI; bumped to version 2.23
Removed references to $wgTitle, $wgUser, and $wgLang.

Follows-up r113297 and I2d9724314f94c216650370071b31390c5c2c97fc.

Bug: 53563
Change-Id: I07fb6939d16a18ecf367ee34ebc176fdc5634dd7
2013-09-03 20:53:20 +02:00
Wikinaut feaf0e186b trim white spaces around urls in feed item <link> or <id> tags
Change-Id: I2a8098cb5f0f8b01bf6b82f850bcbdfd8597be2d
2013-06-09 07:18:29 +00:00
csteipp 05e4e8fa64 Prevent xxe when loading feed XML
Turn off external entity loading while parsing feed xml.

bug: 46932
Change-Id: I41006fc10f2da1357d57c1566518c86351f522f1
2013-04-15 13:23:25 -07:00
Wikinaut 2fa8bc3cd7 follow-up change (renaming) core class HttpRequest to MWHttpRequest
Change-Id: I2c44ab3323c6da8f4b787a8fd0e36d451115e92d
2013-03-04 00:05:06 +01:00
Wikinaut 08f2300932 (bug 45387) (bug 45388) $wgRSSAllowImageTag new name; bug fixed
+++ breaking change +++
variable name $wgAllowImageTag renamed to $wgRSSAllowImageTag

+ fixed a problem that $wgAllowImageTag was not obeyed
+ added $wgRSSAllowImageTag to the variable declaration list in RSS.php

Change-Id: I112ebcdf492dfe80ba187fe6ab2406d3eed10f6a
2013-03-03 19:47:20 +00:00
Thomas Gries afa5cff8a9 version 2.18 + squashed commit RSS changes fromSVN
bump version number from 2.17 to 2.18 for the releas version

removed 4 white spaces tabs.

followed the advices of the code reviewer. removed an unwanted switch(true) structure
removed switch case by an assoc array, removed unneeded http factory comments Wikinaut 2013-01-04

removed unneeded INSTALL text file
new version 2.17 incl. code cosmetics. rebased on master bea4447d24  2012-12-22
bear with me ! It's my first real-life commit to gerrit. Wikinaut, 2012-12-30

Catrope squashed these together per Wikinaut's request. List of commit
summaries:

adding the long-wanted date format attribute.
implemented a date format equalising function,
so that dates of RSS feeds are rendered in a common format.

follow-up r111347 : adding escapeTemplateParameter around the user supplied optional date attribute

fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item <description>

follow-up r111350 . check if optional parameter  isset and is_numeric, otherwise limit to the built-in default (30000)

removed a wrong comment regarding PHP 5.3 function date_create_from_format,
which is not suited to auto-detect a time string in any formats -  only strtotime() can do it.

follow-up r111350 r111351 . switch replaced by if elseif construct.

name and behaviour change of wgRSSAllowedFeeds towgRSSUrlWhitelist.
The wgRSSUrlWhitelist is _now_ empty by default which was not the case until this version.
Admins who want to allow their users to insert arbitrary feed urls must now denote this expressly
with an asterisk in quotes as whitelist array element.
This is harmonised to the same method as recently introduced in E:EtherpadLite.
The RELEASE NOTES file has been updated, updates to the MediaWiki manual page will follow soon.

increased wgRSSFetchTimeout default from 5 to 15 seconds - many sites are too slow.

v2.00 can parse ATOM feeds, at least some.
This is a major improvement over pre-2.00 versions which only could read and parse RSS feeds but no ATOM feeds.
Version 2.00 begins to keep care of namespaces in the XML.
The parser still leaves room for further improvements.
At least, E:RSS can now read E:WikiArticleFeeds generated RSS _and_ ATOM feeds.

v2.01 fixed ATOM summary element was forgotten to be parsed.
Added handling of basic HTML layout tags (p br b u i s) in feed descriptions,
they are preserved in the wiki output after sanitizing.

improved code legibility function namespacePrefixedQuery

fix for ultra bug 30028 .
The RSS extension can parse RSS and ATOM feeds of different flavours.
The php xml dom xpath query uses now a namespace-safe method to find all elements like item (RSS, RDF)
or entry (ATOM).
Further fixed a hidden problem when the feed url was redirecting,
this threw the Cannot parse RSS for XML error, which is now history.
Introduced a new parameter wgRSSUrlNumberOfAllowedRedirects which defaults to zero,
i.e. no redirects are allowed by default. See Manual page

removed superfluous code for setting userAgent since r112466

function name typo correction. Version number update

fix for bug34763 'RSS feed items (HTML) are not rendered as HTML but htmlescaped';
tolerated controlled regression bug30377 'feed item length limitation',
because this now becomes very tricky when we allow some tags in order to close bug 34763.

add tracking category feature (enabled by default). Each page using this extensions gets
automatically the tracking category with MediaWiki:Rss-tracking-category name (= RSS).
Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned.
Documentation of the switch is inline and follows on MediaWiki.

follow up r113508 : escaped html tag brackets to make translaters happy

beautifying the tracking category name

adding casts. better ?

removed the redundant code for handling tracking categories.
By using '-' for the message text rss-tracking-category , this can be disabled easily.

+ Patchset 11

rebased on master

+ Patchset 12

wrapped commit message text lines
version number bumped to 2.18

+ Patchset 13

improved and updated README
added history of the present version 2.18

+ Patchset 14

white space fixes
version number fixes

Change-Id: I2d9724314f94c216650370071b31390c5c2c97fc
2013-02-20 20:10:11 +01:00
Siebrand Mazeland 876e323eb6 Maintenance for RSS extension.
* Replace deprecated methods.
* Remove superfluous newlines.
* Update docs.
* Remove unused local variable.

Change-Id: I38e053980c40fdaf2ffa43a664c03f34a82b5e7c
2012-10-07 12:11:49 +02:00
Roan Kattouw f31547eb82 Revert r111347, r111348, r111350, r111351, r111515, r111816, r112243, r112251, r112308, r112314, r112315, r112465, r112467, r112709, r113297, r113508, r113510, r113524, r113546, r114168. Unreviewed revisions in the RSS extension and their dependencies.
All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
2012-03-21 18:40:06 +00:00
Thomas Gries 660bd56b73 removed the redundant code for handling tracking categories. By using '-' for the message text rss-tracking-category , this can be disabled easily. 2012-03-19 18:56:58 +00:00
Thomas Gries ca38b650d8 add tracking category feature (enabled by default). Each page using this extensions get automatically the tracking category with MediaWiki:Rss-tracking-category name (= RSS). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. 2012-03-09 19:43:44 +00:00
Thomas Gries 832948bb19 fix for bug34763 'RSS feed items (HTML) are not rendered as HTML but htmlescaped'; tolerated controlled regression bug30377 'feed item length limitation', because this now becomes very tricky when we allow some tags in order to close bug 34763. 2012-03-07 21:06:35 +00:00
Thomas Gries 4865be2f69 removed superfluous code for setting userAgent since r112466 2012-02-27 01:44:30 +00:00
Thomas Gries 896a9a3274 fix for ultra bug 30028 . The RSS extension can parse RSS and ATOM feeds of different flavours. The php xml dom xpath query uses now a namespace-safe method to find all elements like item (RSS, RDF) or entry (ATOM). Further fixed a hidden problem when the feed url was redirecting, this threw the Cannot parse RSS for XML error, which is now history. Introduced a new parameter wgRSSUrlNumberOfAllowedRedirects which defaults to zero, i.e. no redirects are allowed by default. See Manual page 2012-02-27 01:10:57 +00:00
Thomas Gries 83a5de7cd7 v2.01 fixed ATOM summary element was forgotten to be parsed. Added handling of basic HTML layout tags (p br b u i s) in feed descriptions, they are preserved in the wiki output after sanitizing. 2012-02-24 11:37:35 +00:00
Thomas Gries b276af44d9 v2.00 can parse ATOM feeds, at least some. This is a major improvement over pre-2.00 versions which only could read and parse RSS feeds but no ATOM feeds. Version 2.00 begins to keep care of namespaces in the XML. The parser still leaves room for further improvements. At least, E:RSS can now read E:WikiArticleFeeds generated RSS _and_ ATOM feeds. 2012-02-24 10:16:34 +00:00
Thomas Gries 01c12d4927 name and behaviour change of wgRSSAllowedFeeds towgRSSUrlWhitelist. The wgRSSUrlWhitelist is _now_ empty by default which was not the case until this version. Admins who want to allow their users to insert arbitrary feed urls must now denote this expressly with an asterisk in quotes as whitelist array element. This is harmonised to the same method as recently introduced in E:EtherpadLite. The RELEASE NOTES file has been updated, updates to the MediaWiki manual page will follow soon. 2012-02-23 21:12:54 +00:00
Thomas Gries 778820623b follow-up r111350 r111351 . switch replaced by if elseif construct. 2012-02-18 07:35:23 +00:00
Thomas Gries 7ea7412751 removed a wrong comment regarding PHP 5.3 function date_create_from_format, which is not suited to auto-detect a time string in any formats - only strtotime() can do it. 2012-02-15 00:11:14 +00:00
Thomas Gries b9f38de383 follow-up r111350 . check if optional parameter isset and is_numeric, otherwise limit to the built-in default (30000) 2012-02-13 07:36:01 +00:00
Thomas Gries f54d6b047b fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item <description> 2012-02-13 07:23:56 +00:00
Thomas Gries 46e1da3b14 follow-up r111347 : adding escapeTemplateParameter around the user supplied optional date attribute 2012-02-13 01:49:50 +00:00
Thomas Gries e0d4f1dc22 adding the long-wanted date format attribute. implemented a date format equalising function, so that dates of RSS feeds are rendered in a common format. 2012-02-13 01:39:24 +00:00
Sam Reed ac778b6394 Fix unused variables
Fix trailing whitespace

Add/Improve documentation

Explicit member variable declaration
2012-01-28 17:05:20 +00:00
Thomas Gries 1850d615a0 follow-up to r94579. Fixed white spaces 2012-01-20 21:46:31 +00:00
Thomas Gries 06e9fa6c74 new version RSS 1.90: streamlined template use, extended documentation; replaced parsing of each single channel subelement (item) by one final parser call when rendering 2011-08-15 21:52:08 +00:00
Jeroen De Dauw a789ea5969 added paramater to change the template name, fixing bug 26479 2011-05-14 15:10:40 +00:00
Sam Reed 334d5e60b0 Fixup a few bits of documentation 2011-01-08 01:33:42 +00:00
Tim Starling 4606c89f74 Proxy configuration feature, since $wgHTTPProxy tends to screw up unrelated code. 2010-11-25 12:38:25 +00:00
Tim Starling 87d6eb6c7d * Avoid XSS via malicious RSS on wikis with $wgRawHtml = true. Mostly reverts r77031.
* Avoid formatting errors due to RSS descriptions which contain "}}", which was ending the item template prematurely.
2010-11-23 02:16:05 +00:00
Mark A. Hershberger 6003693caf followup r76848 by using wfEscapeWikiText() on all bits except links. Escape links using wfEscapeWikiText() that, after we've parsed them with parse_url(), don't have a scheme in our list of validSchemes. 2010-11-19 21:02:01 +00:00
Mark A. Hershberger b6befdf40b followup r76848 Make sure to use wfEscapeWikiText 2010-11-19 19:01:09 +00:00
Mark A. Hershberger d997781fb4 * Remove references to unused charset handling.
* Remove references to unused config variables.
* Consolidate renderItem() to a single loop instead of a separate one for highlighting displayFields.
* Make sure everything gets htmlspecialchars() treatment.
o
2010-11-16 23:21:36 +00:00
Mark A. Hershberger a5321b114b * Remove the call to disableCache(), that, upon double-checking, does undermine the caching that updateCacheExpiry() is trying to set up in the very next line.
* Fix renderItem so that it isn't overly complex and just subsitutes the parsed contents of RSS elements (e.g. {{{description}}} is substituted with the contents of the <description> tag).
2010-11-16 22:06:59 +00:00
Roan Kattouw 61f5f7caba RSS extension:
* Prefix memcached keys with 'rss'
* Check is_array() rather than != null before using list() on the cache entry
* Fix language in comment
2010-11-13 19:16:39 +00:00
Roan Kattouw ff4e370bed RSS: instanceOf -> instanceof, $ERROR -> $error 2010-11-13 19:11:28 +00:00
Jack Phoenix 4e23b840bc RSS: coding style and documentation tweaks 2010-11-05 00:59:28 +00:00
Mark A. Hershberger 4a06accf23 don't fail where itemTemplate is filled with 0s 2010-11-04 23:47:06 +00:00
Mark A. Hershberger 3aa74a03f8 Re Roan's new review on IRC yesterday:
* Add function documentation that I should have written before.
* Create separate RSSParser class to clean up RSS.php
* Create separate RSSHooks class to handle parser initialization and
  public interface for parser to use.
* Move User Agent definition to $wgRSSUserAgent from a define.
* Eliminate references to $wgRSSUseGzip (since were using MW's
  internal HTTP client, it didn't do anything anyway, ATM).

Re Tim's emailed review (discovered yesterday):
* Switch to DOMXPath::query() from DOMXPath::evaluate() at Tim's
  suggestion.
* Move highlighting callback to its own class, RSSHighlighter, so that
  it works as a callback without create_function() and other mess.
2010-11-04 23:19:00 +00:00