mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-28 01:10:04 +00:00
30863cfae5
Not all relevant combinations of flags are currently covered by tests. Change-Id: I6276d591185d08a46ffa69b710e1d28c01536b76
206 lines
5.7 KiB
JavaScript
206 lines
5.7 KiB
JavaScript
import * as stubs from './stubs';
|
|
import isReferencePreviewsEnabled from '../../src/isReferencePreviewsEnabled';
|
|
|
|
function createStubUserSettings( expectEnabled ) {
|
|
return {
|
|
isReferencePreviewsEnabled() {
|
|
return expectEnabled !== false;
|
|
}
|
|
};
|
|
}
|
|
|
|
QUnit.module( 'ext.popups#isReferencePreviewsEnabled', {
|
|
beforeEach() {
|
|
mw.user = { options: { get: () => '1' } };
|
|
},
|
|
afterEach() {
|
|
mw.user = null;
|
|
}
|
|
} );
|
|
|
|
QUnit.test( 'all relevant combinations of flags', ( assert ) => {
|
|
[
|
|
{
|
|
testCase: 'enabled for an anonymous user',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: true,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: false,
|
|
expected: true
|
|
},
|
|
{
|
|
testCase: 'turned off via the feature flag (anonymous user)',
|
|
wgPopupsReferencePreviews: false,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: true,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
testCase: 'not available because of a conflicting gadget (anonymous user)',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: true,
|
|
isMobile: false,
|
|
isAnon: true,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
testCase: 'not available in the mobile skin (anonymous user)',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: true,
|
|
isAnon: true,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
testCase: 'manually disabled by the anonymous user',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: true,
|
|
enabledByAnon: false,
|
|
enabledByRegistered: true,
|
|
expected: false
|
|
},
|
|
{
|
|
testCase: 'enabled for a registered user',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: false,
|
|
enabledByAnon: false,
|
|
enabledByRegistered: true,
|
|
expected: true
|
|
},
|
|
{
|
|
testCase: 'turned off via the feature flag (registered user)',
|
|
wgPopupsReferencePreviews: false,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: false,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
testCase: 'not available because of a conflicting gadget (registered user)',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: true,
|
|
isMobile: false,
|
|
isAnon: false,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
testCase: 'not available in the mobile skin (registered user)',
|
|
wgPopupsReferencePreviews: true,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: true,
|
|
isAnon: false,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: true,
|
|
expected: null
|
|
},
|
|
{
|
|
// TODO: This combination will make much more sense when the server-side
|
|
// wgPopupsReferencePreviews flag doesn't include the user's setting any more
|
|
testCase: 'manually disabled by the registered user',
|
|
wgPopupsReferencePreviews: false,
|
|
wgPopupsConflictsWithRefTooltipsGadget: false,
|
|
isMobile: false,
|
|
isAnon: false,
|
|
enabledByAnon: true,
|
|
enabledByRegistered: false,
|
|
expected: null
|
|
}
|
|
].forEach( ( data ) => {
|
|
const user = { isAnon: () => data.isAnon },
|
|
userSettings = {
|
|
isReferencePreviewsEnabled: () => data.isAnon ?
|
|
data.enabledByAnon :
|
|
assert.ok( false, 'not expected to be called' )
|
|
},
|
|
config = {
|
|
get: ( key ) => key === 'skin' && data.isMobile ? 'minerva' : data[ key ]
|
|
};
|
|
|
|
if ( data.isAnon ) {
|
|
mw.user.options.get = () => assert.ok( false, 'not expected to be called' );
|
|
} else {
|
|
mw.user.options.get = () => data.enabledByRegistered ? '1' : '0';
|
|
}
|
|
|
|
assert.strictEqual(
|
|
isReferencePreviewsEnabled( user, userSettings, config ),
|
|
data.expected,
|
|
data.testCase
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'it should display reference previews when conditions are fulfilled', ( assert ) => {
|
|
const user = stubs.createStubUser( false ),
|
|
userSettings = createStubUserSettings( false ),
|
|
config = new Map();
|
|
|
|
config.set( 'wgPopupsReferencePreviews', true );
|
|
config.set( 'wgPopupsConflictsWithRefTooltipsGadget', false );
|
|
|
|
assert.ok(
|
|
isReferencePreviewsEnabled( user, userSettings, config ),
|
|
'If the user is logged in and the user is in the on group, then it\'s enabled.'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'it should handle the conflict with the Reference Tooltips Gadget', ( assert ) => {
|
|
const user = stubs.createStubUser( false ),
|
|
userSettings = createStubUserSettings( false ),
|
|
config = new Map();
|
|
|
|
config.set( 'wgPopupsReferencePreviews', true );
|
|
config.set( 'wgPopupsConflictsWithRefTooltipsGadget', true );
|
|
|
|
assert.notOk(
|
|
isReferencePreviewsEnabled( user, userSettings, config ),
|
|
'Reference Previews is disabled.'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'it should not be enabled when the global is disabling it', ( assert ) => {
|
|
const user = stubs.createStubUser( false ),
|
|
userSettings = createStubUserSettings( false ),
|
|
config = new Map();
|
|
|
|
config.set( 'wgPopupsReferencePreviews', false );
|
|
config.set( 'wgPopupsConflictsWithRefTooltipsGadget', false );
|
|
|
|
assert.notOk(
|
|
isReferencePreviewsEnabled( user, userSettings, config ),
|
|
'Reference Previews is disabled.'
|
|
);
|
|
} );
|
|
|
|
QUnit.test( 'it should not be enabled when minerva skin used', ( assert ) => {
|
|
const user = stubs.createStubUser( false ),
|
|
userSettings = createStubUserSettings( false ),
|
|
config = new Map();
|
|
|
|
config.set( 'wgPopupsReferencePreviews', true );
|
|
config.set( 'wgPopupsConflictsWithRefTooltipsGadget', false );
|
|
config.set( 'skin', 'minerva' );
|
|
|
|
assert.notOk(
|
|
isReferencePreviewsEnabled( user, userSettings, config ),
|
|
'Reference Previews is disabled.'
|
|
);
|
|
} );
|