mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-30 18:34:40 +00:00
fe32c48268
This was motivated by two things: 1. Notice the bad class name in UserPreferencesChangeHandlerTest. This was possible because the default mock builder does not check if a class exists, *and* there was no type hint in place. createMock() *does* check if a class exists. 2. We are free to use createMock() from PHPUnit 5+ now. It's not only shorter but more strict and reliable. Change-Id: I301a171d587026eab0a62575ab2fdbfd7733c661
67 lines
1.9 KiB
PHP
67 lines
1.9 KiB
PHP
<?php
|
|
/*
|
|
* This file is part of the MediaWiki extension Popups.
|
|
*
|
|
* Popups is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Popups is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Popups. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @file
|
|
* @ingroup extensions
|
|
*/
|
|
use Popups\EventLogging\MWEventLogger;
|
|
use Popups\EventLogging\NullLogger;
|
|
use Popups\EventLogging\EventLoggerFactory;
|
|
|
|
/**
|
|
* @group Popups
|
|
* @coversDefaultClass \Popups\EventLogging\EventLoggerFactory
|
|
*/
|
|
class EventLoggerFactoryTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @covers ::__construct
|
|
* @covers ::get
|
|
* @covers \Popups\EventLogging\MWEventLogger::__construct
|
|
*/
|
|
public function testReturnsMWEventWhenEventLoggingIsAvailable() {
|
|
$mock = $this->createMock( ExtensionRegistry::class );
|
|
$mock->expects( $this->once() )
|
|
->method( 'isLoaded' )
|
|
->with( 'EventLogging' )
|
|
->willReturn( true );
|
|
|
|
$factory = new EventLoggerFactory( $mock );
|
|
$this->assertInstanceOf( MWEventLogger::class,
|
|
$factory->get(),
|
|
'A functional event logger is instantiated.' );
|
|
}
|
|
|
|
/**
|
|
* @covers ::__construct
|
|
* @covers ::get
|
|
*/
|
|
public function testReturnsMWEventWhenEventLoggingIsNotAvailable() {
|
|
$mock = $this->createMock( ExtensionRegistry::class );
|
|
$mock->expects( $this->once() )
|
|
->method( 'isLoaded' )
|
|
->with( 'EventLogging' )
|
|
->willReturn( false );
|
|
|
|
$factory = new EventLoggerFactory( $mock );
|
|
$this->assertInstanceOf( NullLogger::class,
|
|
$factory->get(),
|
|
'A no-op event logger is instantiated.' );
|
|
}
|
|
|
|
}
|