mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-18 21:05:57 +00:00
0282b9648f
Improving Hovercards' settings dialog to fulfill design specification. Also fixing HTML structure by removing invalid `radiogroup` element and adding missing `</div>` element, fixing related QUnit test. Changes: * Add close icon instead of using text * Style header as a table for alignment * Remove redundant "OK" button and have it replace "Save" instead * Update text of "OK" button to "Done" * Fix description for translation of "Done" button * Fix qunit and selenium tests * Remove unnecessary markup and less * Add mediawiki-ui-button and mediawiki-ui-icon dependencies * Shrink dialog width some per design spec * Fix dialog horizontal position calculation to remove hard-coded value Bug: T138612 Change-Id: I7395e3438836149becdd576942bdaf6f21b4163f
19 lines
832 B
Ruby
19 lines
832 B
Ruby
# Standard article page
|
|
class ArticlePage
|
|
include PageObject
|
|
|
|
page_url '<%= URI.encode(params[:article_name]) %>'\
|
|
'<%= URI.encode(params[:query_string]) if params[:query_string] %>'\
|
|
'<%= params[:hash] %>'
|
|
div(:page_header, css: '#mw-head')
|
|
a(:first_valid_link, css: 'ul a', index: 0)
|
|
div(:hovercard, css: '.mwe-popups')
|
|
a(:settings_icon, css: '.mwe-popups-settings-icon')
|
|
radio(:enable_previews_radio, id: 'mwe-popups-settings-simple')
|
|
radio(:disable_previews_radio, id: 'mwe-popups-settings-off')
|
|
div(:cancel_settings_button, css: '#mwe-popups-settings .close', index: 0)
|
|
button(:save_settings_button, css: '#mwe-popups-settings .save')
|
|
button(:settings_help_ok_button, css: '#mwe-popups-settings .okay', index: 0)
|
|
a(:last_link_in_the_footer, css: '#footer-places a', index: -1)
|
|
end
|