wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups
833 commits 280 branches 0 tags 66 MiB
JavaScript 84.7%
PHP 9.9%
Less 5%
Shell 0.4%
Go to file
joakin e49103061e Don't reset interaction info when dwelling back to a link 
When dwelling back to a link, previously a new LINK_DWELL action would
be sent and the reducer would reset the interaction as if it was a new
one.

This shouldn't happen, since dwelling back to the active link (from
the preview, for example) is not a new interaction, and should not
create a new interaction or hide and show the preview.

With this change, the preview reducer has the notion of new or repeat
interactions, and only resets state on new ones, and only sets
isUserDwelling when dwelling on a the link of the current interaction.

Also when the interaction is repeat, we guard on the action creator and
don't trigger the wait or the fetch request.

Change-Id: I71cde81cbfe50b6f955e562e7e5b57d0f920fdb9
2017-01-10 17:44:37 -08:00
doc Wire up saving enabled/disabled in settings dialog 2016-12-14 14:35:59 +00:00
i18n Update enable previews copy 2017-01-09 19:41:44 +01:00
images Directory structure should reflect the ResourceLoader definitions 2016-10-19 20:52:40 +00:00
includes Hygiene: use UserGetDefaultOptions instead of ExtensionRegistration 2017-01-10 18:34:43 +01:00
resources Don't reset interaction info when dwelling back to a link 2017-01-10 17:44:37 -08:00
tests Don't reset interaction info when dwelling back to a link 2017-01-10 17:44:37 -08:00
.eslintrc.json Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
.gitignore Add composer.json 2015-11-19 14:30:20 +01:00
.gitreview Make mpga the default branch for git-review 2016-11-08 21:00:21 +00:00
.stylelintrc Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
composer.json build: Updating development dependencies 2016-01-05 10:39:25 -08:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Hygiene: use UserGetDefaultOptions instead of ExtensionRegistration 2017-01-10 18:34:43 +01:00
Gemfile Update mediawiki_api gem to 1.7.1 2016-05-26 01:34:35 +02:00
Gemfile.lock Hygiene: Remove RL-related step 2016-12-13 14:46:03 +00:00
Gruntfile.js Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
jsduck.json Setup jsduck to run on 'npm run doc' 2015-08-03 15:54:25 +05:30
package.json Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
Popups.hooks.php Hygiene: use UserGetDefaultOptions instead of ExtensionRegistration 2017-01-10 18:34:43 +01:00
Popups.php Add extension.json, empty php entry point 2015-07-02 22:19:24 +00:00