wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-13 17:56:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups
1474 commits 279 branches 0 tags 65 MiB
JavaScript 84.7%
PHP 9.8%
Less 5%
Shell 0.5%
Go to file
Stephen Niedzielski e406d4556f Fix: don't assume thumbnail URLs contain pixel size 
Don't assume that thumbnail URLs contain a dimension delimiter of "px-".
Previously, thumbnail URLs always contained the width. e.g.:

  https://upload.wikimedia.org/wikipedia/commons/a/aa/100px-Red_Giant_Earth_warm.jpg

However, thumbnail URLs that actually point to the original are not
sizable:

  https://upload.wikimedia.org/wikipedia/commons/a/aa/Red_Giant_Earth_warm.jpg

These are provided, for example, when the thumbnail size requested is
larger than the original. There was code designed to handle this
scenario but it only applies when RESTBase and page preview thumbnail
sizes happen to be in sync. In other words, if RESTBase requests a large
thumbnail on behalf of page previews, and page previews only requested a
small thumbnail, the original may be unexpectedly provided. A
conditional is introduced in this patch to verify that "px-" is actually
detected. If it is not present, the original is used.

Bug: T187955
Change-Id: If4e29dd870aecd6d461cc8203f6576d1bb8844f2
2018-02-22 12:36:30 -06:00
doc Docs: Fix typo in Grafana link label 2017-08-26 00:08:03 +01:00
i18n Localisation updates from https://translatewiki.net. 2018-02-19 22:25:48 +01:00
images BetaFeatures logo: Merge logo and title path 2017-11-28 10:30:37 -08:00
includes Capture page view-like interactions 2018-02-16 23:03:33 +00:00
resources Fix: don't assume thumbnail URLs contain pixel size 2018-02-22 12:36:30 -06:00
src Fix: don't assume thumbnail URLs contain pixel size 2018-02-22 12:36:30 -06:00
tests Fix: don't assume thumbnail URLs contain pixel size 2018-02-22 12:36:30 -06:00
.eslintrc.es5.json Run eslint on compiled assets to ensure code is es5 compatible 2017-09-07 12:30:33 +02:00
.eslintrc.json Limit line length to 80 characters 2018-01-19 14:20:39 +01:00
.gitattributes Hygiene: Move build/ext.popups/ to src/ 2017-02-14 09:59:59 -08:00
.gitignore Generate docs inside doc folder 2017-05-30 10:16:57 -04:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Hygiene: Tidy up QUnit references 2017-05-04 15:53:44 +01:00
.phpcs.xml build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 2017-12-30 02:19:18 +00:00
.stylelintrc.json build: Update linters 2018-02-04 22:09:45 +00:00
CODE_OF_CONDUCT.md Add CODE_OF_CONDUCT.md 2017-06-07 15:30:07 +04:30
composer.json build: Updating mediawiki/minus-x to 0.3.1 2018-02-18 07:12:34 +00:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Hygiene: Page view -> Pageview 2018-02-21 18:51:49 +00:00
Gruntfile.js build: Always exclude vendor 2017-11-10 17:42:04 +00:00
jsdoc.json Generate docs inside doc folder 2017-05-30 10:16:57 -04:00
package-lock.json Updating mw-node-qunit to v3 2018-02-08 12:20:52 +01:00
package.json Fix: don't assume thumbnail URLs contain pixel size 2018-02-22 12:36:30 -06:00
Popups.php Hygiene: Update required MediaWiki version 2017-07-24 16:12:03 +02:00
README.md Add code coverage reports npm script 2017-03-03 13:34:33 +01:00
webpack.config.js Do not include @nomin instruction in dist build 2017-10-11 14:34:18 -07:00

README.md

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:node
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:node"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder