mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-24 07:34:11 +00:00
ddf574afa3
Note how getIsEnabled() is documented: "if the user hasn't previously enabled or disabled Page Previews […] then they are treated as if they have enabled them." In other words: The idea that the default should be true is encoded twice in this code. This is just not necessary. We can remove one without loosing anything. Motivtion: Simplifying the code and reducing the package size. Since the code fundamentally depends on this default value anyway, we can clear the users localStorage when they decide to go back to the default – instead of storing a "1" which does the same as the default. Change-Id: I2814a1e9269979918609162a508eeee6944d9e52 |
||
|---|---|---|
| .. | ||
| changeListeners | ||
| gateway | ||
| instrumentation | ||
| integrations | ||
| preview | ||
| reducers | ||
| ui | ||
| .eslintrc.json | ||
| actions.test.js | ||
| bracketedPixelRatio.test.js | ||
| changeListener.test.js | ||
| container.test.js | ||
| counts.test.js | ||
| experiments.test.js | ||
| formatter.test.js | ||
| getPageviewTracker.test.js | ||
| integration.test.js | ||
| isPagePreviewsEnabled.test.js | ||
| isReferencePreviewsEnabled.test.js | ||
| previewBehavior.test.js | ||
| run.js | ||
| setUserConfigFlags.test.js | ||
| stubs.js | ||
| title.test.js | ||
| userSettings.test.js | ||
| wait.test.js | ||