mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-15 03:34:03 +00:00
d1c0613186
This happened one time before and was fixed via T212419. It now came back after I2670331, a patch for T214861 that made the title parser accept more links than before. This patch implements a decision tree that goes as follows: 1. If it's a link to another page, it can't be anything but a page preview, as having a peek into another page is effectively the definition of a page preview. 2. Otherwise it's probably a reference preview, but only if: * It's a link with a jump mark. * The link is actually marked as being a "reference". * Reference previews are enabled. 3. If neither of these definitions fit, do nothing. Note this is not "hiding errors" we would be able to fix in this code. There are many ways to manually arrange wikitext in a way that it looks like one or the other, without fulfilling all requirements. Unfortunately the user who would see error message or dysfunctional popups would not be the same as the user who wrote such wikitext. Bug: T216683 Change-Id: I8d021f19ddc73a261e6a0c62959ddd0cb1d3182d |
||
|---|---|---|
| .. | ||
| changeListeners | ||
| gateway | ||
| instrumentation | ||
| integrations | ||
| preview | ||
| reducers | ||
| ui | ||
| .eslintrc.json | ||
| actions.test.js | ||
| bracketedPixelRatio.test.js | ||
| changeListener.test.js | ||
| container.test.js | ||
| counts.test.js | ||
| experiments.test.js | ||
| formatter.test.js | ||
| getPageviewTracker.test.js | ||
| integration.test.js | ||
| isEnabled.test.js | ||
| previewBehavior.test.js | ||
| run.js | ||
| stubs.js | ||
| title.test.js | ||
| userSettings.test.js | ||
| wait.test.js | ||