wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-09-23 18:29:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups
1305 commits 270 branches 0 tags 63 MiB
JavaScript 83.4%
PHP 11.3%
Less 4.9%
Shell 0.4%
Go to file
Piotr Miazga d07441ec7f getPreviewCountBucket should return unknown when no bucket is found 
Under some unknown circumstances getPreviewCountBucket() is called
with a value that is not a -1 or a natural number. When that happens
function returns 'undefined bucket' which causes eventLogging to
fail. I wasn't able to reproduce the issue, it might be specific
to browser/os. The safest way is to return 'unknown' for any other
case.

Bug: T168371
Change-Id: I374bb629762a86ac06a18e775d3c1a14682c9f55
2017-08-15 16:12:26 +02:00
doc Document decision to cache requests 2017-06-22 07:12:49 +01:00
i18n Localisation updates from https://translatewiki.net. 2017-08-14 09:27:07 +02:00
images Optimise SVGs with svgo 2017-04-26 17:15:45 +01:00
includes build: Updating mediawiki/mediawiki-codesniffer to 0.11.0 2017-08-11 00:21:26 -04:00
resources getPreviewCountBucket should return unknown when no bucket is found 2017-08-15 16:12:26 +02:00
src getPreviewCountBucket should return unknown when no bucket is found 2017-08-15 16:12:26 +02:00
tests getPreviewCountBucket should return unknown when no bucket is found 2017-08-15 16:12:26 +02:00
.eslintrc.json Use EcmaScript modules instead of common.js modules 2017-07-31 23:05:44 +00:00
.gitattributes Hygiene: Move build/ext.popups/ to src/ 2017-02-14 09:59:59 -08:00
.gitignore Generate docs inside doc folder 2017-05-30 10:16:57 -04:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Hygiene: Tidy up QUnit references 2017-05-04 15:53:44 +01:00
.stylelintrc Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
CODE_OF_CONDUCT.md Add CODE_OF_CONDUCT.md 2017-06-07 15:30:07 +04:30
composer.json build: Updating mediawiki/mediawiki-codesniffer to 0.11.0 2017-08-11 00:21:26 -04:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Disable Previews on blacklisted pages 2017-07-31 09:10:30 -04:00
Gemfile doc: Replace JSDuck v5.3.4 with JSDoc v3.4.3 2017-05-23 05:33:31 +01:00
Gemfile.lock Hygiene: Remove RL-related step 2016-12-13 14:46:03 +00:00
Gruntfile.js Remove eslint:fix 2017-05-03 10:19:31 +01:00
jsdoc.json Generate docs inside doc folder 2017-05-30 10:16:57 -04:00
package.json Merge "Use EcmaScript modules instead of common.js modules" 2017-08-07 22:13:51 +00:00
phpcs.xml build: Updating mediawiki/mediawiki-codesniffer to 0.11.0 2017-08-11 00:21:26 -04:00
Popups.php Hygiene: Update required MediaWiki version 2017-07-24 16:12:03 +02:00
README.md Add code coverage reports npm script 2017-03-03 13:34:33 +01:00
webpack.config.js Enable production settings for the production bundle 2017-05-11 10:37:45 +02:00

README.md

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:node
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:node"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder