mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-15 11:46:55 +00:00
cb362d125c
Replace all test assertions for calledOnce / Twice with callCount.
assert.ok( calledOnce / Twice ) only lets the dev know that a test
fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging
process when it fails since it provides the difference in the failure
output. strictEqual() was deliberately used since it's a saner default
and the codebase already favors === equivalency checks.
find tests -name \*.js|
xargs -rd\\n sed -ri '
s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g;
s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g;
'
Change-Id: I07c3c6d20e07c5b8107583a01d820e3fbd68a4e1
87 lines
2.7 KiB
JavaScript
87 lines
2.7 KiB
JavaScript
/* global Promise */
|
|
import getPageviewTracker, { getSendBeacon } from '../../src/getPageviewTracker';
|
|
|
|
QUnit.module( 'ext.popups#getPageviewTracker', {
|
|
beforeEach: function () {
|
|
this.makeBeaconUrl = this.sandbox.stub();
|
|
this.prepare = this.sandbox.stub();
|
|
this.trackerGetter = () => ( { makeBeaconUrl: this.makeBeaconUrl,
|
|
prepare: this.prepare } );
|
|
this.loader = () => Promise.resolve();
|
|
this.Title = {
|
|
newFromText: this.sandbox.stub()
|
|
};
|
|
mediaWiki.Title = this.Title;
|
|
},
|
|
afterEach() {
|
|
mediaWiki.Title = null;
|
|
}
|
|
} );
|
|
|
|
const enabledConfig = {
|
|
get: () => true
|
|
};
|
|
|
|
QUnit.test( 'getPageviewTracker', function ( assert ) {
|
|
const loader = this.sandbox.stub();
|
|
const sendBeacon = this.sandbox.stub();
|
|
|
|
/* eslint-disable camelcase */
|
|
const data = {
|
|
page_title: 'Test title',
|
|
source_title: 'Source title',
|
|
page_namespace: 1,
|
|
source_url: 'http://some/url'
|
|
};
|
|
const eventData = {
|
|
page_title: 'Test_title',
|
|
source_title: 'Source_title',
|
|
page_namespace: 1,
|
|
source_url: 'http://some/url'
|
|
};
|
|
this.Title.newFromText.withArgs( data.page_title ).returns( {
|
|
getPrefixedDb: () => eventData.page_title
|
|
} );
|
|
this.Title.newFromText.withArgs( data.source_title ).returns( {
|
|
getPrefixedDb: () => eventData.source_title
|
|
} );
|
|
/* eslint-enable camelcase */
|
|
const tracker = getPageviewTracker( enabledConfig,
|
|
loader, this.trackerGetter, sendBeacon );
|
|
|
|
loader.resolves();
|
|
return tracker( 'event.VirtualPageView', data ).then( () => {
|
|
assert.strictEqual( loader.callCount, 1, 'loader called once' );
|
|
assert.ok( loader.calledWith( [ 'ext.eventLogging', 'schema.VirtualPageView' ] ),
|
|
'appropriate code is loaded' );
|
|
assert.strictEqual( this.Title.newFromText.callCount, 2 );
|
|
assert.ok( this.prepare.calledWith( 'VirtualPageView', eventData ),
|
|
'mw.eventLog.prepare called appropriately' );
|
|
assert.strictEqual( this.makeBeaconUrl.callCount, 1,
|
|
'makeBeacon called with result of prepare' );
|
|
assert.strictEqual( sendBeacon.callCount, 1,
|
|
'sendBeacon called with url from makeBeaconUrl' );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'getSendBeacon', function ( assert ) {
|
|
let success = false;
|
|
const navtr = {
|
|
successful: true,
|
|
sendBeacon: function () {
|
|
// This local variable helps test context. Don't refactor.
|
|
success = this.successful;
|
|
}
|
|
};
|
|
const sendBeacon = getSendBeacon( navtr );
|
|
sendBeacon();
|
|
assert.ok( success, 'native sendBeacon is used when available and run in appropriate context' );
|
|
} );
|
|
|
|
QUnit.test( 'getSendBeacon (fallback)', function ( assert ) {
|
|
const spy = this.sandbox.spy( document, 'createElement' );
|
|
const sendBeacon = getSendBeacon( {} );
|
|
sendBeacon();
|
|
assert.strictEqual( spy.callCount, 1, 'an img element is used as fallback' );
|
|
} );
|