mediawiki-extensions-Popups/src/actions.js
Stephen Niedzielski c7e742743b Doc: fix fetch delay comments
FETCH_COMPLETE_TARGET_DELAY is used to introduce an artificial delay to
HTTP requests as needed. However, FETCH_START_DELAY is always accounted
for so it makes sense to define FETCH_COMPLETE_TARGET_DELAY with it. The
docs are updated to draw the distinction between total delay and API
response delay.

Change-Id: I4cddc89b8090d54db0dd85f270441cab17c54993
2018-10-17 16:44:16 -06:00

436 lines
11 KiB
JavaScript

/**
* @module actions
*/
import types from './actionTypes';
import wait from './wait';
import { createNullModel, previewTypes } from './preview/model';
const $ = jQuery,
mw = mediaWiki,
// See the following for context around this value.
//
// * https://phabricator.wikimedia.org/T161284
// * https://phabricator.wikimedia.org/T70861#3129780
FETCH_START_DELAY = 150, // ms.
// The minimum time a preview must be open before we judge it
// has been seen.
// See https://phabricator.wikimedia.org/T184793
PREVIEW_SEEN_DURATION = 1000, // ms
// The delay after which a FETCH_COMPLETE action should be dispatched.
//
// If the API endpoint responds faster than 350 ms (or, say, the API
// response is served from the UA's cache), then we introduce a delay of
// 350 ms - t to make the preview delay consistent to the user. The total
// delay from start to finish is 500 ms.
FETCH_COMPLETE_TARGET_DELAY = 350 + FETCH_START_DELAY, // ms.
ABANDON_END_DELAY = 300; // ms.
/**
* Mixes in timing information to an action.
*
* Warning: the `baseAction` parameter is modified and returned.
*
* @param {Object} baseAction
* @return {Object}
*/
function timedAction( baseAction ) {
baseAction.timestamp = mw.now();
return baseAction;
}
/**
* Represents Page Previews booting.
*
* When a Redux store is created, the `@@INIT` action is immediately
* dispatched to it. To avoid overriding the term, we refer to booting rather
* than initializing.
*
* Page Previews persists critical pieces of information to local storage.
* Since reading from and writing to local storage are synchronous, Page
* Previews is booted when the browser is idle (using
* [`mw.requestIdleCallback`](https://developer.mozilla.org/en-US/docs/Web/API/Window/requestIdleCallback))
* so as not to impact latency-critical events.
*
* @param {boolean} isEnabled See `isEnabled.js`
* @param {mw.user} user
* @param {ext.popups.UserSettings} userSettings
* @param {mw.Map} config The config of the MediaWiki client-side application,
* i.e. `mw.config`
* @param {string} url url
* @return {Object}
*/
export function boot(
isEnabled,
user,
userSettings,
config,
url
) {
const editCount = config.get( 'wgUserEditCount' ),
previewCount = userSettings.getPreviewCount();
return {
type: types.BOOT,
isEnabled,
isNavPopupsEnabled: config.get( 'wgPopupsConflictsWithNavPopupGadget' ),
sessionToken: user.sessionId(),
pageToken: user.getPageviewToken(),
page: {
url,
title: config.get( 'wgTitle' ),
namespaceId: config.get( 'wgNamespaceNumber' ),
id: config.get( 'wgArticleId' )
},
user: {
isAnon: user.isAnon(),
editCount,
previewCount
}
};
}
/**
* Represents Page Previews fetching data via the gateway.
*
* @param {Gateway} gateway
* @param {mw.Title} title
* @param {Element} el
* @param {string} token The unique token representing the link interaction that
* triggered the fetch
* @return {Redux.Thunk}
*/
export function fetch( gateway, title, el, token ) {
const titleText = title.getPrefixedDb(),
namespaceId = title.namespace;
return ( dispatch ) => {
const xhr = gateway.getPageSummary( titleText );
dispatch( timedAction( {
type: types.FETCH_START,
el,
title: titleText,
namespaceId,
promise: xhr
} ) );
const chain = xhr
.then( ( result ) => {
dispatch( timedAction( {
type: types.FETCH_END,
el
} ) );
return result;
} )
.catch( ( err, data ) => {
const exception = new Error( err );
const type = data && data.textStatus && data.textStatus === 'abort' ?
types.FETCH_ABORTED : types.FETCH_FAILED;
exception.data = data;
dispatch( {
type,
el
} );
// Keep the request promise in a rejected status since it failed.
throw exception;
} );
return $.when(
chain,
wait( FETCH_COMPLETE_TARGET_DELAY - FETCH_START_DELAY )
)
.then( ( result ) => {
dispatch( {
type: types.FETCH_COMPLETE,
el,
result,
token
} );
} )
.catch( ( ex ) => {
const result = ex.data;
let showNullPreview = true;
// All failures, except those due to being offline or network error,
// should present "There was an issue displaying this preview".
// e.g.:
// - Show (timeout): data="http" {xhr: {…}, textStatus: "timeout",
// exception: "timeout"}
// - Show (bad MW request): data="unknown_action" {error: {…}}
// - Show (RB 4xx): data="http" {xhr: {…}, textStatus: "error",
// exception: "Bad Request"}
// - Show (RB 5xx): data="http" {xhr: {…}, textStatus: "error",
// exception: "Service Unavailable"}
// - Suppress (offline or network error): data="http"
// result={xhr: {…}, textStatus: "error", exception: ""}
// - Abort: data="http"
// result={xhr: {…}, textStatus: "abort", exception: "abort"}
if ( result && result.xhr && result.xhr.readyState === 0 ) {
const isNetworkError = result.textStatus === 'error' && result.exception === '';
showNullPreview = !( isNetworkError || result.textStatus === 'abort' );
}
if ( showNullPreview ) {
dispatch( {
type: types.FETCH_COMPLETE,
el,
result: createNullModel( titleText, title.getUrl() ),
token
} );
}
} );
};
}
/**
* Represents the user dwelling on a link, either by hovering over it with
* their mouse or by focussing it using their keyboard or an assistive device.
*
* @param {mw.Title} title
* @param {Element} el
* @param {Event} event
* @param {Gateway} gateway
* @param {Function} generateToken
* @return {Redux.Thunk}
*/
export function linkDwell( title, el, event, gateway, generateToken ) {
const token = generateToken(),
titleText = title.getPrefixedDb(),
namespaceId = title.namespace;
return ( dispatch, getState ) => {
const promise = wait( FETCH_START_DELAY );
const action = timedAction( {
type: types.LINK_DWELL,
el,
event,
token,
title: titleText,
namespaceId,
promise
} );
dispatch( action );
// Has the new generated token been accepted?
function isNewInteraction() {
return getState().preview.activeToken === token;
}
if ( !isNewInteraction() ) {
return $.Deferred().resolve().promise();
}
return promise.then( () => {
const previewState = getState().preview;
if ( previewState.enabled && isNewInteraction() ) {
return dispatch( fetch( gateway, title, el, token ) );
}
} );
};
}
/**
* Represents the user abandoning a link, either by moving their mouse away
* from it or by shifting focus to another UI element using their keyboard or
* an assistive device, or abandoning a preview by moving their mouse away
* from it.
*
* @return {Redux.Thunk}
*/
export function abandon() {
return ( dispatch, getState ) => {
const { activeToken: token, promise } = getState().preview;
if ( !token ) {
return $.Deferred().resolve().promise();
}
// Immediately abandon any outstanding fetch request. Do not wait.
promise.abort();
dispatch( timedAction( {
type: types.ABANDON_START,
token
} ) );
return wait( ABANDON_END_DELAY )
.then( () => {
dispatch( {
type: types.ABANDON_END,
token
} );
} );
};
}
/**
* Represents the user clicking on a link with their mouse, keyboard, or an
* assistive device.
*
* @param {Element} el
* @return {Object}
*/
export function linkClick( el ) {
return timedAction( {
type: types.LINK_CLICK,
el
} );
}
/**
* Represents the user dwelling on a preview with their mouse.
*
* @return {Object}
*/
export function previewDwell() {
return {
type: types.PREVIEW_DWELL
};
}
/**
* Represents a preview being shown to the user.
*
* This action is dispatched by the `./changeListeners/render.js` change
* listener.
*
* @param {string} token
* @return {Object}
*/
export function previewShow( token ) {
return ( dispatch, getState ) => {
dispatch(
timedAction( {
type: types.PREVIEW_SHOW,
token
} )
);
return wait( PREVIEW_SEEN_DURATION )
.then( () => {
const state = getState(),
preview = state.preview,
fetchResponse = preview && preview.fetchResponse,
currentToken = preview && preview.activeToken,
validType = fetchResponse && [
previewTypes.TYPE_PAGE,
previewTypes.TYPE_DISAMBIGUATION
].indexOf( fetchResponse.type ) > -1;
if (
// Check the pageview can still be associated with original event
currentToken && currentToken === token &&
// and the preview is still active and of type `page`
fetchResponse && validType
) {
dispatch( {
type: types.PREVIEW_SEEN,
title: fetchResponse.title,
pageId: fetchResponse.pageId,
// The existing version of summary endpoint does not
// provide namespace information, but new version
// will. Given we only show pageviews for main namespace
// this is hardcoded until the newer version is available.
namespace: 0
} );
}
} );
};
}
/**
* Represents the situation when a pageview has been logged
* (see previewShow and PREVIEW_SEEN action type)
*
* @return {Object}
*/
export function pageviewLogged() {
return {
type: types.PAGEVIEW_LOGGED
};
}
/**
* Represents the user clicking either the "Enable previews" footer menu link,
* or the "cog" icon that's present on each preview.
*
* @return {Object}
*/
export function showSettings() {
return {
type: types.SETTINGS_SHOW
};
}
/**
* Represents the user closing the settings dialog and saving their settings.
*
* @return {Object}
*/
export function hideSettings() {
return {
type: types.SETTINGS_HIDE
};
}
/**
* Represents the user saving their settings.
*
* N.B. This action returns a Redux.Thunk not because it needs to perform
* asynchronous work, but because it needs to query the global state for the
* current enabled state. In order to keep the enabled state in a single
* place (the preview reducer), we query it and dispatch it as `wasEnabled`
* so that other reducers (like settings) can act on it without having to
* duplicate the `enabled` state locally.
* See docs/adr/0003-keep-enabled-state-only-in-preview-reducer.md for more
* details.
*
* @param {boolean} enabled if previews are enabled or not
* @return {Redux.Thunk}
*/
export function saveSettings( enabled ) {
return ( dispatch, getState ) => {
dispatch( {
type: types.SETTINGS_CHANGE,
wasEnabled: getState().preview.enabled,
enabled
} );
};
}
/**
* Represents the queued event being logged `changeListeners/eventLogging.js`
* change listener.
*
* @param {Object} event
* @return {Object}
*/
export function eventLogged( event ) {
return {
type: types.EVENT_LOGGED,
event
};
}
/**
* Represents the queued statsv event being logged.
* See `mw.popups.changeListeners.statsv` change listener.
*
* @return {Object}
*/
export function statsvLogged() {
return {
type: types.STATSV_LOGGED
};
}