Go to file
Thiemo Kreuz b28f48d6d6 Rename variables in change listeners for clarity
This patch does nothing but rename a pair of variables:
"prevState/state" becomes "oldState/newState". Reasoning:

1. The abbreviated "prev" is confusing, especially because we
are in a codebase that is all about "previews".

2. We are in a context that is all about a state **change**.
Change listeners get notified about the change from one state
to another. While it would be possible to stick to the already
mentioned "previous/current" terminology, I find the word
"current" confusing. What is "current" in this context? Did
the state already change? Am I notified about a change that is
**going** to happen or already happened? Is this even relevant?
I don't think it is. Therefor "old/new".

Another possibility is "previous/next".

Change-Id: Id886e1a095967fe86fb9021f59e335c62da8994e
2021-04-15 10:19:40 +02:00
.phan Add phan 2019-04-25 20:54:33 +02:00
.storybook Fix storybook IMG assets 2021-01-05 19:50:40 +00:00
docs Rename variables in change listeners for clarity 2021-04-15 10:19:40 +02:00
i18n Localisation updates from https://translatewiki.net. 2021-04-15 08:43:55 +02:00
includes Separate page and reference preview preferences 2021-03-29 14:09:27 +02:00
resources Rename variables in change listeners for clarity 2021-04-15 10:19:40 +02:00
src Rename variables in change listeners for clarity 2021-04-15 10:19:40 +02:00
tests Rename variables in change listeners for clarity 2021-04-15 10:19:40 +02:00
.babelrc Move browserslist targets to new file and change targets 2019-02-11 17:37:03 -07:00
.browserslistrc Move browserslist targets to new file and change targets 2019-02-11 17:37:03 -07:00
.eslintrc.json build: Update eslint-config-wikimedia to 0.16.2 2020-06-26 17:05:56 +01:00
.gitattributes build: Update eslint-config-wikimedia to 0.16.2 2020-06-26 17:05:56 +01:00
.gitignore add /tests/selenium/log to .gitignore file 2020-10-15 10:37:49 -07:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Hygiene: Tidy up QUnit references 2017-05-04 15:53:44 +01:00
.nvmrc Upgrade from node 6 to node 10, now that CI is running that 2019-06-03 14:51:51 -07:00
.nycrc.json Switch from babel-preset-env to @babel/preset-env 2018-12-11 13:09:45 +05:30
.phpcs.xml build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 2020-11-17 23:23:29 +01:00
.stylelintrc.json build: Update linters 2018-02-04 22:09:45 +00:00
.svgo.json build: Bring SVGO optimization to build step 2018-08-01 10:51:43 -05:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 2018-08-19 15:37:11 +00:00
composer.json build: Updating mediawiki/mediawiki-codesniffer to 35.0.0 2021-02-26 23:42:29 +01:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
Doxyfile docs: Generate documentation with Doxygen 2020-02-24 17:10:53 +00:00
extension.json Add title attribute to settings gear icon 2021-04-02 13:30:07 -06:00
Gruntfile.js build: Remove maxWarnings: 0 from eslint configuration 2020-12-28 21:56:11 -08:00
jsdoc.json Hygiene: make JSDoc configs consistent 2018-07-23 14:45:14 -05:00
package-lock.json build: Update eslint-config-wikimedia 2020-09-30 00:46:58 +02:00
package.json Add title attribute to settings gear icon 2021-04-02 13:30:07 -06:00
popups.svg Remove BetaFeature code 2018-04-26 15:51:48 -07:00
README.md Rename many functions and files for clarity 2021-04-08 11:04:02 +02:00
webpack.config.js Expand userSettings module for reference previews 2021-04-13 12:19:49 +02:00

Popups

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change. Additionally, this builds debug-friendly assets and enables Redux DevTools debugging.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:unit
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:unit"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder

Developers are likely to work with local MediaWiki instances that do not have content to test with. To reduce this pain, you can create a single page with a list of links that point to an existing and external wiki by using the following config flag:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'https://en.wikipedia.org/api/rest_v1/page/summary/';

Popups works with a local copy of the Mobile Content Service too:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'http://localhost:6927/en.wikipedia.org/v1/page/summary/';

Debugging

  • Popups are dismissed ("abandoned") when the cursor leaves the popup container. As such, it can be difficult to debug a popup of interest without it popping in and out of the DOM. A useful workaround in DevTools is to context click a link, select inspect, move the cursor some place comfortable, and then from the console enter $($0).trigger('mouseenter').
  • As described in #Development, npm start enables Redux DevTools functionality. In production builds, this same functionality can be enabled by setting a debug=true query. E.g., https://en.wikipedia.org/wiki/Popup?debug=true.
  • When a QUnit test fails but you can't see why, open package.json and temporarily remove the snippet | tap-mocha-reporter dot.

Storybook.js Component Library

The root of the repository contains a .storybook directory. This folder contains a separate NPM project using the Storybook.js UI framework. This framework provides an environment that showcases all possible permutations of popups, without the state-management constraints of having only one popup per page.

This framework requires Node 8 (because of the spread ... operator) and is therefore separated from the main package.json until CI upgrades from Node 6. NVM can be used to manage multiple Node versions to run the Storybook app (cd .storybook && nvm use). See the .storybook/README.md for details.

Building the documentation

Execute npm -s run doc.

Terminology

  • Footnote - What the Cite extension shows at the bottom of the page.
  • Hovercard - Deprecated term for popup.
  • Link preview - A similar user feature in the Android native app.
  • Navpop / nav pop - A popup-like UI from the NavigationPopups gadget.
  • Popup - Generic term for a dialog that appears to float above a link that is being hovered over by a cursor.
  • Page preview - A specific type of popup that shows a page summary.
  • Preview - A synonym for popup.
  • Reference - A specific type of popup that previews the Cite extension's footnotes. Since footnotes are typically used for references, and the tag's name is <ref>, the terms are used synonymously.