mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-15 03:34:03 +00:00
ab4eff82e4
Since the state was cloned into an empty object with $.extend, undefined properties were being deleted from it, not actually preserving those keys. So: nextState({hi: undefined, ho: 1}, {ho: 2}) //> {ho: 2} It seems like a more consistent behavior would be to not lose any own keys on the state as we do with the updates too, so that: nextState({hi: undefined, ho: 1}, {ho: 2}) //> {hi: undefined, ho: 2} Which is what this commit does by not using $.extend to clone the state and instead just manually copy the keys to the new object, even the undefined ones. Change-Id: If4f2a3b0d25bb5ef34cfbc1f2c9c0b5479aeee9b |
||
---|---|---|
.. | ||
ext.popups | ||
ext.popups.core | ||
ext.popups.desktop | ||
ext.popups.images | ||
ext.popups.lib | ||
ext.popups.schemaPopups | ||
ext.popups.schemaPopups.utils |