mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-11 23:36:07 +00:00
a702c0f499
* New action added PREVIEW_SEEN * The action will be used to signal that a page view needs to be recorded. * PREVIEW_SEEN is a delayed action which is triggered as a side-effect of the previewShow action. It is only dispatched if the user is still previewing the same card and the page related to the card has preview type `page` * The pageview changelistener is added when $wgPopupsVirtualPageViews is set to true. * The page view changelistener listens for page views and logs them using EventLogging when needed using https://meta.wikimedia.org/wiki/Schema:VirtualPageView Note: * Currently if a user has enabled the DNT header, the event will not be logged. There is ongoing discussion on the ticket and fixing this will be addressed separately. * Only title and referrer are logged in the initial version. The task demands that "namespace" is logged but this information is not provided by the summary endpoints we use so will need to be added later (if indeed needed) either via a change to that endpoint of by using JavaScript to parse the URL. Bug: T184793 Change-Id: Id1fe34e4bdada3a41f0d888a753af366d4756590 |
||
---|---|---|
doc | ||
i18n | ||
images | ||
includes | ||
resources | ||
src | ||
tests | ||
.eslintrc.es5.json | ||
.eslintrc.json | ||
.gitattributes | ||
.gitignore | ||
.gitreview | ||
.istanbul.yml | ||
.phpcs.xml | ||
.stylelintrc.json | ||
CODE_OF_CONDUCT.md | ||
composer.json | ||
COPYING | ||
extension.json | ||
Gruntfile.js | ||
jsdoc.json | ||
package-lock.json | ||
package.json | ||
Popups.php | ||
README.md | ||
webpack.config.js |
mediawiki/extensions/Popups
See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.
Development
Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.
You can find the frontend source files in src/
, the compiled sources in
resources/dist/
, and other frontend assets managed by resource loader in
resources/*
.
After an npm install
:
- On one terminal, kickstart the bundler process:
npm start
Will run the bundler in watch mode, re-assembling the files on file change.npm run build
Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
- On another terminal, run tests and linting tools:
npm test
To run the linting tools and the tests.- You can find the QUnit tests that depend on running MediaWiki under
tests/qunit/
- You can find the isolated QUnit tests under
tests/node-qunit/
, which you can run withnpm run test:node
- You can find the QUnit tests that depend on running MediaWiki under
- We recommend you install a file watcher like
nodemon
to watch sources and auto run linting and tests.npm install -g nodemon
- Example running linting and node unit tests:
nodemon -w src/ --exec "grunt lint:all && npm run test:node"
- Get code coverage report with
npm run coverage
- Reports printed in the
coverage/
folder
- Reports printed in the