mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-12 09:18:59 +00:00
8f408e2937
npm scripts are run under sh. globstar support is only available in bash > 4 with globstar enabled, so **/*.js was actually being resolved to */*.js only running tests 2 directories deep. This made the test mediawiki.test.js not run since it was moved to the 3rd level deep folder (and actually broke), resulting in: 208 tests 403 passed With this change, it fixes getting the test files, and fixes the mediawiki.test.js, resulting in: 215 tests 413 passed instead. This makes it work everywhere and as nested as it will get for now. Will consider adding glob support to mw-node-qunit later for easier use in other projects too. Bug: T165018 Change-Id: Id0164b2673c8afe8a24fd0eb4aa255c134253862 |
||
---|---|---|
doc | ||
i18n | ||
images | ||
includes | ||
resources | ||
src | ||
tests | ||
.eslintrc.json | ||
.gitattributes | ||
.gitignore | ||
.gitreview | ||
.istanbul.yml | ||
.stylelintrc | ||
CODE_OF_CONDUCT.md | ||
composer.json | ||
COPYING | ||
extension.json | ||
Gemfile | ||
Gemfile.lock | ||
Gruntfile.js | ||
jsdoc.json | ||
package.json | ||
phpcs.xml | ||
Popups.php | ||
README.md | ||
webpack.config.js |
mediawiki/extensions/Popups
See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.
Development
Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.
You can find the frontend source files in src/
, the compiled sources in
resources/dist/
, and other frontend assets managed by resource loader in
resources/*
.
After an npm install
:
- On one terminal, kickstart the bundler process:
npm start
Will run the bundler in watch mode, re-assembling the files on file change.npm run build
Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
- On another terminal, run tests and linting tools:
npm test
To run the linting tools and the tests.- You can find the QUnit tests that depend on running MediaWiki under
tests/qunit/
- You can find the isolated QUnit tests under
tests/node-qunit/
, which you can run withnpm run test:node
- You can find the QUnit tests that depend on running MediaWiki under
- We recommend you install a file watcher like
nodemon
to watch sources and auto run linting and tests.npm install -g nodemon
- Example running linting and node unit tests:
nodemon -w src/ --exec "grunt lint:all && npm run test:node"
- Get code coverage report with
npm run coverage
- Reports printed in the
coverage/
folder
- Reports printed in the