mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-24 04:53:04 +00:00
7d2de31fd9
I played around with a lot of options, and settled with: * When there is nothing but text, but the text is all whitespace, don't show it. * Make sure an <img> with no text is still shown. This is done by checking for child elements. A possible future enhancement could be to check the visible width of the element as well. Unfortunately this fails in tests. Everything is 0 in tests. Bug: T240543 Depends-On: I2929a86b6a09f3b72e5e2f4151cb13f52446897d Change-Id: I94ed575abcd69241c82480ade07017e61cc26c9c
165 lines
4.9 KiB
JavaScript
165 lines
4.9 KiB
JavaScript
import { createStubTitle } from '../stubs';
|
|
import createReferenceGateway from '../../../src/gateway/reference';
|
|
|
|
QUnit.module( 'ext.popups/gateway/reference', {
|
|
beforeEach() {
|
|
mw.msg = ( key ) => `<${key}>`;
|
|
|
|
this.$sourceElement = $( '<a>' ).appendTo(
|
|
$( '<sup>' ).attr( 'id', 'cite_ref-1' ).appendTo( document.body )
|
|
);
|
|
|
|
this.$references = $( '<ul>' ).append(
|
|
$( '<li>' ).attr( 'id', 'cite_note-1' ).append(
|
|
$( '<span>' ).addClass( 'mw-reference-text' ).text( 'Footnote 1' )
|
|
),
|
|
$( '<li>' ).attr( 'id', 'cite_note-2' ).append(
|
|
$( '<span>' ).addClass( 'reference-text' ).append(
|
|
$( '<cite>' ).addClass( 'citation web unknown' ).text( 'Footnote 2' )
|
|
)
|
|
),
|
|
$( '<li>' ).attr( 'id', 'cite_note-3' ).append(
|
|
$( '<span>' ).addClass( 'reference-text' ).append(
|
|
$( '<cite>' ).addClass( 'news' ).text( 'Footnote 3' ),
|
|
$( '<cite>' ).addClass( 'news citation' ),
|
|
$( '<cite>' ).addClass( 'citation' )
|
|
)
|
|
),
|
|
$( '<li>' ).attr( 'id', 'cite_note-4' ).append(
|
|
$( '<span>' ).addClass( 'reference-text' ).append(
|
|
$( '<cite>' ).addClass( 'news' ).text( 'Footnote 4' ),
|
|
$( '<cite>' ).addClass( 'web' )
|
|
)
|
|
),
|
|
$( '<li>' ).attr( 'id', 'cite_note-5' ).append(
|
|
$( '<span>' ).addClass( 'mw-reference-text' ).html( ' ' )
|
|
)
|
|
).appendTo( document.body );
|
|
},
|
|
afterEach() {
|
|
mw.msg = null;
|
|
|
|
this.$references.remove();
|
|
}
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway returns the correct data', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-1' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
|
|
assert.propEqual(
|
|
result,
|
|
{
|
|
url: '#cite_note-1',
|
|
extract: 'Footnote 1',
|
|
type: 'reference',
|
|
referenceType: null,
|
|
sourceElementId: undefined
|
|
}
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway accepts alternative text node class name', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-2' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
|
|
assert.propEqual(
|
|
result,
|
|
{
|
|
url: '#cite_note-2',
|
|
extract: '<cite class="citation web unknown">Footnote 2</cite>',
|
|
type: 'reference',
|
|
referenceType: 'web unknown',
|
|
sourceElementId: undefined
|
|
}
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway accepts duplicated types', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-3' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
|
|
assert.propEqual(
|
|
result,
|
|
{
|
|
url: '#cite_note-3',
|
|
extract: '<cite class="news">Footnote 3</cite><cite class="news citation"></cite><cite class="citation"></cite>',
|
|
type: 'reference',
|
|
referenceType: 'news',
|
|
sourceElementId: undefined
|
|
}
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway rejects conflicting types', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-4' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( ( result ) => {
|
|
assert.propEqual(
|
|
result,
|
|
{
|
|
url: '#cite_note-4',
|
|
extract: '<cite class="news">Footnote 4</cite><cite class="web"></cite>',
|
|
type: 'reference',
|
|
referenceType: null,
|
|
sourceElementId: undefined
|
|
}
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway returns source element id', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-1' );
|
|
|
|
return gateway.fetchPreviewForTitle( title, this.$sourceElement[ 0 ] ).then( ( result ) => {
|
|
assert.propEqual(
|
|
result,
|
|
{
|
|
url: '#cite_note-1',
|
|
extract: 'Footnote 1',
|
|
type: 'reference',
|
|
referenceType: null,
|
|
sourceElementId: 'cite_ref-1'
|
|
}
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway rejects non-existing references', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'undefined' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( () => {
|
|
assert.ok( false, 'It should not resolve' );
|
|
} ).catch( ( reason, result ) => {
|
|
assert.propEqual( result, { textStatus: 'abort', xhr: { readyState: 0 } } );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway rejects all-whitespace references', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-5' );
|
|
|
|
return gateway.fetchPreviewForTitle( title ).then( () => {
|
|
assert.ok( false, 'It should not resolve' );
|
|
} ).catch( ( reason, result ) => {
|
|
assert.propEqual( result, { textStatus: 'abort', xhr: { readyState: 0 } } );
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'Reference preview gateway is abortable', function ( assert ) {
|
|
const gateway = createReferenceGateway(),
|
|
title = createStubTitle( 1, 'Foo', 'cite note-1' ),
|
|
promise = gateway.fetchPreviewForTitle( title );
|
|
|
|
assert.strictEqual( typeof promise.abort, 'function' );
|
|
} );
|