mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-15 11:46:55 +00:00
76b8c18ca5
Like the FETCH_COMPLETE and ABANDON_END actions, the PREVIEW_SHOW action was delayed but not conditionally reduced. As ABANDON_END is delayed, there's a potential for a race and if ABANDON_END is reduced before PREVIEW_SHOW, then there's no interaction to reduce the action into, which causes an error, e.g. T159490#3165276 and T162373. Making PREVIEW_SHOW require a token stops the error occurring in this scenario. An alternative would be to clear the timeout created in ext.popups.Preview#show in #hide. However, this would be inconsistent with actions#fetch and actions#abandon. Bug: T159490 Change-Id: Ibd2c0c6f45e4392582cc6ed08517f6ca1146d57a |
||
|---|---|---|
| .. | ||
| changeListeners | ||
| gateway | ||
| preview | ||
| reducers | ||
| actions.test.js | ||
| changeListener.test.js | ||
| counts.test.js | ||
| integration.test.js | ||
| isEnabled.test.js | ||
| previewBehavior.test.js | ||
| schema.test.js | ||
| settingsDialog.test.js | ||
| statsvInstrumentation.test.js | ||
| stubs.js | ||
| userSettings.test.js | ||
| wait.test.js | ||