mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-22 12:02:46 +00:00
190962cc5b
An "advanced" option was first introduced in 2014 via patch I374805e (originally named "monitor-or-edit", renamed via patch I7b4f6d2). The isNavPopupsEnabled() function was added in 2016 via patch Ic660f48. The code that disables the extension entirely the moment the NavPopups gadget is enabled was added in 2017 via patch Ia474b1b (T151058) and patch Ia837816 (T160081). As of now, the "advanced" option can only be seen in an extreme edge case: * Only for anonymous users. * Only if NavPopups is enabled by default for anonymous users. * Only if the $wgPopupsConflictingNavPopupsGadgetName setting is misconfigured. * … or if NavPopups is not a gadget in the first place, but e.g. loaded via Common.js. In this situation the settings dialog opens with all *3* options. This is broken for several reasons: * The "simple" option enables the extension, but doesn't disable NavPopups. Both trigger, resulting in both popups being displayed the same time. * Since "simple" is the default, this bogus behavior is the default for anonymous users. * The "off" option doesn't stick. Every time the settings dialog opens "advanced" is checked instead. * "Off" can't work anyway. There is no code to disable the gadget. * Only the "advanced" option "works", but more by accident. It's unclear how to fix this: * There is no code that does anything with the "advanced" option. It's not even stored. The behavior of the option is identical to "off". * The code appears as if "advanced" was meant to be shown instead of "off". I.e. anonymous users can only choose one of the popups, but not disable both. But there is no code to hide the "off" option. * The bug when both popups are displayed was fixed in 2017 via an entirely different mechanism. Re-introducing "advanced" does not only mean duplication, it's unclear how the 2 mechanisms are meant to work together. It really, really feels like this was just forgotten. Bug: T278949 Change-Id: Iab21f3a649a5b2f19ebb0d0dbb45ce1450c65678
51 lines
4.8 KiB
JSON
51 lines
4.8 KiB
JSON
{
|
||
"@metadata": {
|
||
"authors": [
|
||
"Amire80",
|
||
"Liuxinyu970226",
|
||
"Mar(c)",
|
||
"Mateon1",
|
||
"Nemo bis",
|
||
"Raymond",
|
||
"Robby",
|
||
"Shirayuki",
|
||
"Umherirrender"
|
||
]
|
||
},
|
||
"popups-message": "Name shown in user preference for this extension\n{{name}}",
|
||
"popups-desc": "{{desc|name=Popups|url=https://www.mediawiki.org/wiki/Extension:Popups}}",
|
||
"popups-settings-title": "Title used for the setting's dialog",
|
||
"popups-settings-unified-title": "Title used for the setting's dialog enabling page and reference previews. It's a name of a feature and doesn't necessarily have to be plural.",
|
||
"popups-settings-option-simple": "Title for the reader popup option\n{{Identical|Enable}}",
|
||
"popups-settings-option-simple-description": "Description for the reader popup option",
|
||
"popups-settings-option-unified-description": "Description for the reader popup option for page and reference previews",
|
||
"popups-settings-option-off": "Title to turn off popups option.\n\nSee also:\n* {{msg-mw|Popups-settings-enable}}\n{{Identical|Disable}}",
|
||
"popups-settings-save": "Save button for the setting's dialog\n{{Identical|Save}}",
|
||
"popups-settings-help-ok": "Confirmation button after showing how to re-enable page previews.\n{{Identical|Done}}",
|
||
"popups-settings-cancel": "Cancel button for the setting's dialog\n{{Identical|Cancel}}",
|
||
"popups-settings-help": "Help text explaining how to re-enable popups",
|
||
"popups-settings-enable": "Link on the footer to enable popups if its disabled.\n\nSee also:\n* {{msg-mw|Popups-settings-option-off}}",
|
||
"popups-settings-icon-gear-title": "Title attribute of gear icon to change page preview settings.",
|
||
"popups-preview-no-preview": "The message shown to the user when a preview can't be generated.",
|
||
"popups-preview-footer-read": "The link shown to the user when a preview can't be generated.",
|
||
"popups-preview-disambiguation": "The description shown on a preview for a disambiguation page",
|
||
"popups-preview-disambiguation-link": "The link shown on a preview for a disambiguation page",
|
||
"prefs-reading": "Title for 'Reading preferences' section on preferences page; it's a magic message derived from PREVIEWS_PREFERENCES_SECTION (see commit f597e34)",
|
||
"popups-prefs-optin": "Label for Page Previews option (description for Page Previews option)",
|
||
"popups-prefs-disable-nav-gadgets-info": "Help message telling to disable the \"Navigation popups\" gadget in order to enable page previews. The word \"Gadgets\" should be based on {{msg-mw|prefs-gadgets}}.\n\nParameters:\n* $1 – Link to the Gadgets tab in the user's preferences",
|
||
"popups-prefs-conflicting-gadgets-info": "Help message informing about possible conflicts with other gadgets/customizations",
|
||
"popups-prefs-navpopups-gadget-conflict-info": "Help message telling to disable the \"Navigation popups\" gadget in order to allow page and reference previews. The word \"Gadgets\" should be based on {{msg-mw|prefs-gadgets}}.\n\nParameters:\n* $1 – Link to the Gadgets tab in the user's preferences",
|
||
"popups-prefs-reftooltips-gadget-conflict-info": "Help message telling to disable the \"Reference Tooltips\" gadget in order to allow reference previews. The word \"Gadgets\" should be based on {{msg-mw|prefs-gadgets}}.\n\nParameters:\n* $1 – Link to the Gadgets tab in the user's preferences",
|
||
"popups-prefs-reftooltips-and-navpopups-gadget-conflict-info": "Help message telling to disable the \"Navigation popups\" and \"Reference Tooltips\" gadgets in order to allow page and reference previews. The word \"Gadgets\" should be based on {{msg-mw|prefs-gadgets}}.\n\nParameters:\n* $1 – Link to the Gadgets tab in the user's preferences",
|
||
"popups-refpreview-reference": "Default heading for popups that show previews of references as provided by the Cite extension's <ref> tags (also known as footnotes).\n{{Identical|Reference}}",
|
||
"popups-refpreview-book": "Heading for a popup previewing a citation from a book.\n{{Identical|Book}}",
|
||
"popups-refpreview-journal": "Heading for a popup previewing a citation from a journal.\n{{Identical|Journal}}",
|
||
"popups-refpreview-news": "Heading for a popup previewing a citation from the news.\n{{Identical|News}}",
|
||
"popups-refpreview-note": "Heading for a popup previewing a footnote.\n{{Identical|Note}}",
|
||
"popups-refpreview-web": "Heading for a popup previewing a citation from a website.\n{{Identical|Website}}",
|
||
"popups-refpreview-collapsible-placeholder": "Placeholder text for collapsible tables, templates, or other large elements inside of a reference.",
|
||
"popups-refpreview-user-preference-label": "Label for the user option to enable or disable reference preview popups",
|
||
"popups-refpreview-beta-feature-message": "Label for the Reference Previews Beta feature.",
|
||
"popups-refpreview-beta-feature-description": "Description for the Reference Previews Beta feature, describing the feature that will be enabled."
|
||
}
|